Fix clang 15 warning in cxgbe

[dim]

Summary

Clang 15 warns:

sys/dev/cxgbe/cudbg/cudbg_lib.c:2949:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
        int i = 0;
            ^

Apparently 'i' was meant as the current retry counter, but '1' was used
in the while loop comparison instead, making the loop potentially
infinite, if 'busy' never gets reset.

MFC after: 3 days

[np]

sys/dev/cxgbe/cudbg/cudbg_lib.c

2953

Should there be a bitwise or boolean and here?

[dim]

sys/dev/cxgbe/cudbg/cudbg_lib.c

2953

Oh that's a good one. Short-circuit evaluation won't matter in this case, so it should be && instead. I'd also think that busy should be volatile, but it could be that t4_read_reg() takes care of that?

[np]

sys/dev/cxgbe/cudbg/cudbg_lib.c

2953

Yes, the t4_reg_read will take care of that.

[np]

Please commit with boolean &&.