Page MenuHomeFreeBSD

LinuxKPI: extend kfifo to be usable by a driver
ClosedPublic

Authored by bz on Jul 16 2022, 12:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 5:13 PM
Unknown Object (File)
Thu, Jan 23, 6:37 PM
Unknown Object (File)
Oct 4 2024, 4:07 PM
Unknown Object (File)
Sep 5 2024, 8:20 AM
Unknown Object (File)
Sep 3 2024, 3:33 PM
Unknown Object (File)
Sep 1 2024, 4:43 AM
Unknown Object (File)
Aug 17 2024, 9:46 AM
Unknown Object (File)
Aug 2 2024, 9:35 PM

Details

Summary

Implement some basic needs for an actual driver using kfifo.

MFC after: 2 weeks

Test Plan

I had this in user space initially and tested it and it seemed to
work as expected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46453
Build 43342: arc lint + arc unit

Event Timeline

bz requested review of this revision.Jul 16 2022, 12:40 AM
sys/compat/linuxkpi/common/include/linux/kfifo.h
91

Is there a chance of counters wrapping around?

Where is first decremented?

sys/compat/linuxkpi/common/include/linux/kfifo.h
91

First is decremented right below there if it rolls over. It's a FIFO--first and last just move forward (or wrap around).

Now I see. Looks good to me.

This revision is now accepted and ready to land.Jul 17 2022, 6:15 PM

I've done a build against drm-kmod master but I'll wait to hear back from @manu or @wulf on whether it's okay for them too.

It builds for me on master, 5.10-lts and 5.4-lts branches

This revision was automatically updated to reflect the committed changes.