Page MenuHomeFreeBSD

sched_ule: Ensure we hold the thread lock when modifying td_flags
ClosedPublic

Authored by markj on Jul 14 2022, 8:06 PM.
Tags
None
Referenced Files
F103041330: D35821.id.diff
Wed, Nov 20, 4:17 AM
Unknown Object (File)
Sun, Nov 10, 1:19 AM
Unknown Object (File)
Sun, Nov 10, 1:15 AM
Unknown Object (File)
Thu, Nov 7, 11:13 PM
Unknown Object (File)
Tue, Nov 5, 2:37 PM
Unknown Object (File)
Oct 17 2024, 5:34 AM
Unknown Object (File)
Oct 16 2024, 11:32 AM
Unknown Object (File)
Oct 15 2024, 9:59 AM
Subscribers

Details

Summary

The load balancer may force a running thread to reschedule and pick a
new CPU. To do this it sets some flags in the thread running on a
loaded CPU. But it assumes that the thread's lock is equal to that of
the runqueue, and there are small windows where this is not true. In
this case, we can end up with non-atomic modifications to td_flags.

Since this load balancing is best-effort, simply give up if the thread's
lock doesn't match; in this case the thread is about to enter the
scheduler anyway.

Reported by: glebius
Fixes: e745d729be60 ("sched_ule(4): Improve long-term load balancer.")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable