New committer (doc): Pau Amma

[pauamma_gundo.com]

Summary

Approved by: will be either/both mentors, carlavilla and gjb

Test Plan

Feed to dot and check there are no error messages.

Make sure file recognizes the output as a PNG.

[lwhsu]

share/misc/committers-doc.dot

18

Firstly I suggest making this change in a separate commit. For the change itself, I suggest:

• Just mention git log is fine
• In git, it's not in svnadmin/conf/access, it's in "access" file in internal/admin branch as 5.2.2.2 in https://docs.freebsd.org/en/articles/committers-guide/#git-primer

26

same as above.

[pauamma_gundo.com]

share/misc/committers-doc.dot

18

I'll split it off and mention the right location for git.

I looked at the internal/admin log in all 3 repos and they have at least some history from before the switch from svn, but I can't check all of it is present, which would be needed for this use case. Can you confirm it is?

[lwhsu]

share/misc/committers-doc.dot

18

I'll split it off and mention the right location for git.

I looked at the internal/admin log in all 3 repos and they have at least some history from before the switch from svn, but I can't check all of it is present, which would be needed for this use case. Can you confirm it is?

In theorem everything is preserved from cvs->svn and svn->git. There do have some missed parts, but it should be fine because new changes only go to there and the date is used for the .dot file here.

[gjb]

share/misc/committers-doc.dot

18

Actually, we have already lost quite a bit of VCS history from the CVS->SVN conversion *and* the SVN->Git conversion.

Particularly, the admin/svnconf/access, for example - everything (or most) was lost when the www and doc tree were converged into one repository. Then the SVN->Git conversion happened, somewhat in tandem with the conversion from XML to AsciiDOC, where the layout changed yet again.

[lwhsu]

share/misc/committers-doc.dot

18

Oh right, I forgot that part. Anyway, this doesn't affect that the source of truth of the new things.

[gjb]

share/misc/committers-doc.dot

18

Agreed - just playing devil's advocate. :)

[pauamma_gundo.com]

VCS change split off to https://reviews.freebsd.org/D35803. New patch here in a bit.

[pauamma_gundo.com]

Split off git log changes at lwhsu's suggestion.

[pauamma_gundo.com]

Is mentor approval from before I split off the bits unrelated to onboarding enough for me to proceed with the actual commit?

[gjb]

Yes, please go ahead.