committers-doc.dot: add grahamperrin

[grahamperrin]

Summary

Committer's Guide, steps for new committers, step 5.

Mentors: Glen Barber (gjb) and Sergio Carlavilla (carlavilla).

[gjb]

Approved.

[grahamperrin]

View Options ▶ Show Path in Repository

Path Does Not Exist

Also, https://reviews.freebsd.org/D35746#UQ0_10 above, doc should have been src … I don't imagine this being correctable (by me), should I abandon this D35746 and start afresh?

[grahamperrin]

The raw diff from Phabricator didn't work for me with git-apply(1).

Instead, here's a diff produced by GitLab.

[grahamperrin]

share/misc/committers-doc.dot

165–169

I put myself alphabetically between crees and philip, however I see that crees is preceded – not alphabetically – by rene and dru.

Is order negligible, here?

https://cgit.freebsd.org/src/tree/share/misc/committers-doc.dot?id=71e1ff237ed6bdfa2a394e0d2b121aed981865fa#n35 was simply:

# Keep the list sorted by mentor login.

[grahamperrin]

This comment was removed by grahamperrin.

[grahamperrin]

In D35746#811490, @grahamperrin wrote:

… https://reviews.freebsd.org/D35746#UQ0_10 above, doc should have been src … I don't imagine this being correctable (by me), …

☑ Now I see rG FreeBSD src repository – I guess, correction occurred when I uploaded the file for diff 107981.

[carlavilla]

Approved

[grahamperrin]

share/misc/committers-doc.dot

165–169

dot -T png -o /tmp/commiters-doc.png /usr/src/share/misc/committers-doc.dot at a glance, this part of the result looks OK:

– so I guess that order is negligible.

[grahamperrin]

In D35746#813204, @carlavilla wrote:

Approved

Thanks. Not noted in the commit, because I authored the commit around the time of acceptance of an earlier revision.

---

Today's push succeeded:

• https://github.com/freebsd/freebsd-src/commit/1e680803108bd4000bbea4b1d5b4c142ec59e43f
• https://gitlab.com/FreeBSD/freebsd-src/-/commit/1e680803108bd4000bbea4b1d5b4c142ec59e43f
• https://cgit.freebsd.org/src/commit/?id=1e680803108bd4000bbea4b1d5b4c142ec59e43f

---

Attempts yesterday failed, somewhat mysteriously. From an attempt at 21:09 BST:

% time git -C /usr/src push freebsd HEAD:main
Enter passphrase for key '/home/grahamperrin/.ssh/id_rsa':  
load: 0.95  cmd: ssh 22002 [select] 242.59r 0.18u 0.00s 0% 7844k
load: 0.68  cmd: ssh 22002 [select] 645.63r 0.18u 0.00s 0% 7900k
load: 0.64  cmd: ssh 22002 [select] 677.54r 0.18u 0.00s 0% 7900k
^C0.019u 0.000s 11:20.05 0.0%   2472+332k 0+0io 0pf+0w
%

• for a few minutes, whilst awaiting a response, I occasionally keyed Control-T
• Control-C abandoned the attempt.

There's additional context, which I'll not echo here. All things considered, I'm happy for yesterday's events to remain a mystery ☑

---

Success today was partly thanks to a simple git primer (for ports) https://people.freebsd.org/~danfe/git.html (2021-04-16, @danfe), which I stumbled across whilst seeking something completely unrelated to Git. Step 6 there drops a hint that seems to be absent from the Committer's Guide:

• git show HEAD

A transcript (other people might learn from my mistakes):

1e680803108b.txt6 KBDownload

– key points:

• necessarily not using --ff-only https://www.freebsd.org/cgi/man.cgi?query=git-pull&sektion=1&manpath=FreeBSD-Ports#OPTIONS whilst the current branch was D35746
• using --ff-only after temporarily making main current
• today's first git -C /usr/src push freebsd HEAD:main did gain a useful response.

---

FreeBSD bug 261812 – Miscellaneous small changes to the Committer's Guide.