Page MenuHomeFreeBSD

vnet: make VNET_FOREACH() always be a loop
ClosedPublic

Authored by kp on Jul 6 2022, 8:21 PM.
Tags
None
Referenced Files
F116025225: D35739.diff
Thu, May 1, 6:35 PM
Unknown Object (File)
Thu, Apr 24, 7:11 AM
Unknown Object (File)
Fri, Apr 18, 10:02 AM
Unknown Object (File)
Mar 28 2025, 7:18 PM
Unknown Object (File)
Mar 6 2025, 3:53 PM
Unknown Object (File)
Mar 6 2025, 12:09 PM
Unknown Object (File)
Feb 28 2025, 6:54 PM
Unknown Object (File)
Feb 21 2025, 12:05 AM

Details

Summary

VNET_FOREACH() is a LIST_FOREACH if VIMAGE is set, but empty if it's
not. This means that users of the macro couldn't use 'continue' or
'break' as one would expect of a loop.

Change VNET_FOREACH() to be a loop in all cases (although one that is
fixed to one iteration if VIMAGE is not set).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46301
Build 43190: arc lint + arc unit

Event Timeline

kp requested review of this revision.Jul 6 2022, 8:21 PM

I wonder if compiler removes the loop and produces same code after the change.

This revision is now accepted and ready to land.Jul 6 2022, 8:28 PM

I wonder if compiler removes the loop and produces same code after the change.

It does, yes, so this is a no-op, other than making the loop work the way a reader would expect it to, regardless of VIMAGE or ! VIMAGE.

This revision was automatically updated to reflect the committed changes.