Differential D35669

socket: fix listen(2) on an already listening socket
ClosedPublic
Actions

Authored by glebius on Jun 30 2022, 3:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 13, 12:32 AM

	Unknown Object (File)
	Wed, Feb 12, 2:19 AM

	Unknown Object (File)
	Sun, Jan 26, 6:15 PM

	Unknown Object (File)
	Sat, Jan 25, 7:13 AM

	Unknown Object (File)
	Sat, Jan 25, 2:07 AM

	Unknown Object (File)
	Fri, Jan 17, 9:39 PM

	Unknown Object (File)
	Jan 10 2025, 7:41 AM

	Unknown Object (File)
	Jan 5 2025, 9:11 AM

View All 60 Files

Subscribers

Details

Reviewers

Commits

rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket

Summary

Fixes: 141fe2dceeaeefaaffc2242c8652345a081e825a

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jun 30 2022, 3:15 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 30 2022, 3:15 AM

glebius requested review of this revision.Jun 30 2022, 3:15 AM

Harbormaster completed remote builds in B46192: Diff 107575.Jun 30 2022, 3:15 AM

Oops, thanks.

Will you add a test case? I'll write one if not.

This revision is now accepted and ready to land.Jun 30 2022, 2:33 PM

In D35669#808847, @markj wrote:

Oops, thanks.

Will you add a test case? I'll write one if not.

A proper one, that would not only check that syscall didn't fail, but would also exercise the backlog, would require some time. I can't promise one soon. Feel free to write & commit yours. If I start working on a test, I will message you, so we don't do same work.

Closed by commit rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket (authored by glebius). · Explain WhyJun 30 2022, 2:50 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG66c8e3fccf0c: socket: fix listen(2) on an already listening socket.

Revision Contents
Changeset List

Path

Size

sys/

kern/

5 lines

Diff 107600

sys/kern/uipc_socket.c

Loading...