bhyve: Initialize more registers in vcpu_reset().
ClosedPublic
Actions

Authored by corvink on Jun 28 2022, 8:45 AM.

Details

Reviewers

markj
jhb
manu

Group Reviewers

bhyve

Commits

rGa46eccfd27c3: bhyve: Initialize more registers in vcpu_reset()
rG56b8f5b11171: bhyve: Initialize more registers in vcpu_reset()

Summary

Clear CR2, EFER, and R8-15 to zero.

Reset DR6 and DR7 to their documented reset values.

Reset interrupt shadow state.

Document the reason CR0 is reset to a value that doesn't match its documented value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

corvink created this revision.Jun 28 2022, 8:45 AM

Herald added subscribers: rgrimes, imp. · View Herald TranscriptJun 28 2022, 8:45 AM

corvink requested review of this revision.Jun 28 2022, 8:45 AM

corvink mentioned this in D35623: vmm: permit some IPIs to be handled by userspace.Jun 28 2022, 8:49 AM

I would perhaps adjust the commit log to say something more like:

bhyve: Initialize more registers in vcpu_reset().

- Clear CR2, EFER, and R8-15 to zero.

- Reset DR6 and DR7 to their documented reset values.

- Reset interrupt shadow state.

- Document the reason CR0 is reset to a value that doesn't match
   its documented value.

jhb accepted this revision.Jun 30 2022, 6:10 PM

This revision is now accepted and ready to land.Jun 30 2022, 6:10 PM

corvink retitled this revision from bhyve: reset vcpus properly to bhyve: Initialize more registers in vcpu_reset()..Jul 1 2022, 6:03 AM

corvink edited the summary of this revision. (Show Details)

jhb added a child revision: D35623: vmm: permit some IPIs to be handled by userspace.Jul 13 2022, 5:17 PM

Closed by commit rG56b8f5b11171: bhyve: Initialize more registers in vcpu_reset() (authored by corvink, committed by manu). · Explain WhyJul 27 2022, 4:23 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG56b8f5b11171: bhyve: Initialize more registers in vcpu_reset().

corvink added a commit: rGa46eccfd27c3: bhyve: Initialize more registers in vcpu_reset().Dec 9 2022, 1:20 PM