Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Warnings Severity Location Code Message Warning stand/libsa/zfs/blake3.c:314 SPELL1 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 46109 Build 42998: arc lint + arc unit
Event Timeline
Based on OpenZFS bits. I did try to use blake3 sources directly, but headers are still major trap there. Of course there would also be question of generic versus asm implementations, but linker set would help there IMO (linker sets should be supported by most systems).
Testing done: userboot/test is happy to read pool created by: zpool create -O checksum=blake3.
I really really rather you use the files directly. I fought for a long time to get the OpenZFS integration working well, and I really want a better reason for this copying than 'headers are a mess'.
Like before, though, I'm happy to help. Copied files are a huge source of technical debt and we have way way way too much of that in the loader as it is.
TBH, I was expecting this. And yes, I too think, we should get it done proper. But this version is not for nothing - it does prove the feature is working ok for loader.
I agree there's value here: Going from something that works to something better that works is easier than trying to get everything right out of the gate.