tty: Only print stack information on INVARIANT kernels
ClosedPublic
Actions

Authored by imp on Jun 23 2022, 5:14 PM.

Details

Reviewers

mmel
cem
grembo
jhb

Commits

rGac7506f22fa6: tty: Default to printing kernel stack traceback only on INVARIANT kernels
rGb69996d1d5d0: tty: Default to printing kernel stack traceback only on INVARIANT kernels

Summary

In May 2021 in current@ there was a thread about the kstack
inclusion in ^T output. There seemed to be much support for the
default to not include this, unless an invariant kernel is used.
Implement this belatedly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 23 2022, 5:14 PM

imp created this revision.

Harbormaster completed remote builds in B46095: Diff 107300.Jun 23 2022, 5:15 PM

imp added reviewers: mmel, cem.Jun 23 2022, 5:16 PM

imp edited the summary of this revision. (Show Details)

Straightforward and balanced.

Thanks!

This revision is now accepted and ready to land.Jun 23 2022, 5:32 PM

The commit message suggests the entire functionality is axed, as opposed to compiled in but disabled by default.

I would suggest rewording the body of the commit message to something like:

Adjust the default setting for kstack output in ^T to
include kstack output in debug kernels with INVARIANTS
and omit it in non-debug kernels.

The default setting can always be changed via the kern.tty_info_kstacks
sysctl/tunable.

This might address mjg's point?

pi added a subscriber: pi.Jun 23 2022, 6:21 PM

I like jhb's wording and will use something like that in the commit message. It better represents what I'm doing here.

Also, MFC After 1 week is the plan.

Closed by commit rGb69996d1d5d0: tty: Default to printing kernel stack traceback only on INVARIANT kernels (authored by imp). · Explain WhyJul 2 2022, 2:04 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGb69996d1d5d0: tty: Default to printing kernel stack traceback only on INVARIANT kernels.

imp added a commit: rGac7506f22fa6: tty: Default to printing kernel stack traceback only on INVARIANT kernels.Apr 19 2023, 7:46 PM