Page MenuHomeFreeBSD

routing: fix RTM_CHANGE for multipath #1
ClosedPublic

Authored by melifaro on Jun 19 2022, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:45 PM
Unknown Object (File)
Sat, Oct 26, 4:44 PM
Unknown Object (File)
Sat, Oct 26, 4:44 PM
Unknown Object (File)
Sat, Oct 26, 4:44 PM
Unknown Object (File)
Sat, Oct 26, 4:44 PM
Unknown Object (File)
Sat, Oct 26, 4:25 PM
Unknown Object (File)
Mon, Oct 21, 9:14 AM
Unknown Object (File)
Sep 29 2024, 9:43 PM
Subscribers

Details

Summary

RTM_CHANGE is supposed to operate on a single component of the multipath route (e.g. on a single nexthop). Search of this nexthop is peformed by iterating over each nexthop from multipath (nexthop) group, using check_info_match_nhop. The problem with the current code that it (incorrectly assumes that check_info_match_nhop() returns true value on match, while in reality it returns an error code on failure).
Fix this by properly comparing the result with 0.

Next, the followup code creating a new nexthop group, was modifying original group instead of a new one, leading to the spurious errors.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable