Differential D35482

USB: add quirks to XHCI
ClosedPublic
Actions

Authored by bz on Jun 14 2022, 4:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 10:12 PM

	Unknown Object (File)
	Tue, Nov 5, 1:25 PM

	Unknown Object (File)
	Thu, Oct 17, 4:41 PM

	Unknown Object (File)
	Wed, Oct 16, 8:03 PM

	Unknown Object (File)
	Mon, Oct 14, 12:45 AM

	Unknown Object (File)
	Sat, Oct 12, 7:03 PM

	Unknown Object (File)
	Fri, Oct 11, 12:38 PM

	Unknown Object (File)
	Oct 9 2024, 2:08 AM

View All 97 Files

Subscribers

Details

Reviewers

Commits

rG39cd7aa134df: USB: add quirks to XHCI
rG447c418da034: USB: add quirks to XHCI

Summary

While XHCI is very generic some revisions of chipsets have problems.
On dwc3 <= 3.00a Port Disable does not work so we need to not enable PED.
For that introduce quirks to xhci so that controllers can steer
certain features. I would hope that this is and remains the only one.

Obtained from: an old patch mainly debugging other problems

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jun 14 2022, 4:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 14 2022, 4:46 PM

bz requested review of this revision.Jun 14 2022, 4:46 PM

Harbormaster completed remote builds in B45973: Diff 106913.Jun 14 2022, 4:46 PM

bz edited the summary of this revision. (Show Details)Jun 14 2022, 4:46 PM

bz added a subscriber: arm64.

bz added a child revision: D35484: dwc3: fix and add more quirks.Jun 14 2022, 5:03 PM

Looks good.

sys/dev/usb/controller/xhci.h
572	Usually I've just used uint8_t for quirks, but I'm good with this too.

This revision is now accepted and ready to land.Jun 14 2022, 7:41 PM

Use uint32_t instead of enum for quirks; I am going 32 not 8 just in case to not have to change the type in the future. Hope that's okay too.

This revision now requires review to proceed.Jun 14 2022, 9:27 PM

Harbormaster completed remote builds in B45981: Diff 106931.Jun 14 2022, 9:27 PM

bz marked an inline comment as done.Jun 14 2022, 9:30 PM

bz added inline comments.

sys/dev/usb/controller/xhci.h
572	Also in addition to the update comment and enum is sizeof(int) so keeping that matching is probably a good idea.

• hselasky accepted this revision.Jun 15 2022, 7:10 AM

This revision is now accepted and ready to land.Jun 15 2022, 7:10 AM

Closed by commit rG447c418da034: USB: add quirks to XHCI (authored by bz). · Explain WhyJun 15 2022, 9:10 PM

This revision was automatically updated to reflect the committed changes.

bz marked an inline comment as done.

bz added a commit: rG447c418da034: USB: add quirks to XHCI.

bz added a commit: rG39cd7aa134df: USB: add quirks to XHCI.Jul 1 2022, 2:58 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

controller/

7 lines

3 lines

Diff 106972

sys/dev/usb/controller/xhci.h

Loading...

sys/dev/usb/controller/xhci.c

Loading...