Refresh CPU types and classes from sys/sys/pmc.h.

[pauamma_gundo.com]

Summary

While here, fix a few nits.

Assuming that the Arm7 trademark covers ARMv7 as well.

Inspired by reviewing D35342.

Sources for trademark info

• https://www.arm.com/company/policies/trademarks (no Arm8, curiously)
• https://www.ibm.com/legal/copytrade?mhsrc=ibmsearch_a&mhq=trademark

Test Plan

man # and eyeball.
mandoc -T lint
igor

[mhorne]

Thank you for this!

lib/libpmc/pmc.3

176

I believe this also covers POWER9 CPUs.

[pauamma_gundo.com]

lib/libpmc/pmc.3

176

I believe this also covers POWER9 CPUs.

Maybe add that to sys/sys/pmc.h in that case? I went by the current content:

	__PMC_CPU(PPC_POWER8,   0x390,  "IBM POWER8")		\

[luporl]

lib/libpmc/pmc.3

176

It does cover POWER9 CPUs too.

The reason there is only PPC_POWER8 class in sys/sys/pmc.h is that POWER9 counters are programmed exactly like the POWER8 ones.
There are different counters between POWER8 and POWER9, but this only changes the value that must be set to access them. This is handled somewhere in the PMU code, where it queries the model of current CPU.

[pauamma_gundo.com]

Waiting for an answer to my inline question about pmc_close_logfile to update the diff, and I'd still like manpages approval after that.

lib/libpmc/pmc.3

176

Thanks. Will add as a trademark, then.

474

While I'm touching this file: shouldn't this be pmc_close_logfile instead?

[mhorne]

lib/libpmc/pmc.3

474

It seems that pmc_configure_logfile(-1) is used to flush and close any open logfile for the process. The exact difference in intent/functionality between this and pmc_close_logfile() is not obvious on a quick glance.

So, I think it is okay to leave this as-is for now.

[pauamma_gundo.com]

• Add POWER9 trademark

[pauamma_gundo.com]

Review from manpages, ARM, arm64, and PowerPC would be good too.

[carlavilla]

No enough experience on this topic. I prefer to wait for the approval from src

[luporl]

The PowerPC parts look good.

[mhorne]

lib/libpmc/pmc.3

162

Making a note for future work: we ought to find a better solution for this list of AMD and Intel processors. What is here is so outdated as to not be useful (or worse, misleading); instead we need to find the words to communicate that "most AMD and Intel processors are supported", but avoid trying (and failing) to maintain a list of specific CPU models.

[pauamma_gundo.com]

lib/libpmc/pmc.3

162

avoid trying (and failing) to maintain a list of specific CPU models.

Is there an implicit definition that could work instead? *rummages into dmesg.boot* Like whatever test outputs "TSC: P-state invariant, performance statistics" at boot? (13.1 amd64)

[pauamma_gundo.com]

In D35344#842566, @carlavilla wrote:

No enough experience on this topic. I prefer to wait for the approval from src

Which I now have (checked in IRC, and mhorne says their approval is for src overall, including the ARM bits). Can I have mentor approval?