Page MenuHomeFreeBSD
Differential D35317

unix/*: check new control size in unp_internalize()
ClosedPublic
Actions

Authored by glebius on May 25 2022, 7:31 AM.
Tags
None
Referenced Files
F95904996: D35317.id106356.diff
Sun, Sep 22, 11:58 PM
F95904989: D35317.id106374.diff
Sun, Sep 22, 11:58 PM
F95904978: D35317.id.diff
Sun, Sep 22, 11:58 PM
F95903931: D35317.diff
Sun, Sep 22, 11:48 PM
Unknown Object (File)
Sun, Sep 22, 7:09 PM
Unknown Object (File)
Thu, Sep 19, 8:15 PM
Unknown Object (File)
Thu, Sep 19, 8:14 PM
Unknown Object (File)
Mon, Sep 16, 11:47 PM
View All 56 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rG579b45e20328: unix/*: check new control size in unp_internalize()
Summary

Now that we call sbcreatecontrol() with M_WAITOK, we are expected to
pass a valid size. Return same error code, we are returning for an
oversized control from sockargs().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45705
Build 42593: arc lint + arc unit

Event Timeline

glebius created this revision.May 25 2022, 7:31 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2022, 7:31 AM
glebius requested review of this revision.May 25 2022, 7:31 AM
Harbormaster completed remote builds in B45705: Diff 106356.May 25 2022, 7:31 AM
glebius added a parent revision: D35316: sockets: return EMSGSIZE if control part of message is too large.May 25 2022, 7:31 AM
markj accepted this revision.May 25 2022, 7:43 PM
markj added inline comments.
sys/kern/uipc_usrreq.c
2244
2249

I'm not sure this is truly insane. libcasper can provoke such situations.

This revision is now accepted and ready to land.May 25 2022, 7:43 PM
Closed by commit rG579b45e20328: unix/*: check new control size in unp_internalize() (authored by glebius). · Explain WhyMay 25 2022, 8:30 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG579b45e20328: unix/*: check new control size in unp_internalize().

Revision Contents
Changeset List

PathSize
sys/
kern/
14 lines

Diff 106356

View Options

sys/kern/uipc_usrreq.c

Loading...