Page MenuHomeFreeBSD

kevent: Fix an off-by-one in filt_timerexpire_l()
ClosedPublic

Authored by markj on May 24 2022, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 3:04 PM
Unknown Object (File)
Mon, Jan 13, 3:00 AM
Unknown Object (File)
Dec 10 2024, 3:11 PM
Unknown Object (File)
Dec 7 2024, 6:46 AM
Unknown Object (File)
Sep 23 2024, 11:43 PM
Unknown Object (File)
Sep 22 2024, 4:30 AM
Unknown Object (File)
Sep 19 2024, 5:12 AM
Unknown Object (File)
Sep 17 2024, 8:05 PM
Subscribers

Details

Summary

Suppose a periodic kevent timer fires close to its deadline, so now -
kc->next is small. Then delta ends up being 1, and the next timer
deadline is set to (delta + 1) * kc->to, where kc->to is the timer
period. This means that the timer fires at half of the requested rate.
And, because the computation of delta rounds down, it seems that the
kn_data value is incorrect as well.

PR: 264131
Fixes: 7cb40543e964 ("filt_timerexpire: do not iterate over the interval")

Test Plan

I have some updates to the libkqueue regression test which detect this bug.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable