Just remove one level of indentation as the case clause always match.
Details
Details
- Reviewers
markj - Group Reviewers
network transport - Commits
- rGf384a97c839a: unix/dgram: cleanup uipc_send of PF_UNIX/SOCK_DGRAM, step 2
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Warnings Severity Location Code Message Warning sys/kern/uipc_usrreq.c:1012 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_usrreq.c:1013 SPELL1 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 45676 Build 42564: arc lint + arc unit
Event Timeline
| sys/kern/uipc_usrreq.c | ||
|---|---|---|
| 1103 | Seems weird that we honour PRUS_EOF even in the error case. I'm not sure if it's a bug or not. | |
| sys/kern/uipc_usrreq.c | ||
|---|---|---|
| 1103 | Oh, I noticed that, too. :) There is no real use of MSG_EOF. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261699 Notice that all failed programs aren't real applications, but tools that want to exercise all possible socket APIs. In the base system there inetd(8), that would use MSG_EOF on TCP sockets for its builtins. Nobody in the world uses inetd builtins. There are no test cases for MSG_EOF. MSG_EOF exist only in FreeBSD and Mac OS X. My first intent was to remove it. But @tuexen thinks it is a cool feature and promised to cover it with tests :) Anyway, fixing MSG_EOF for PF_UNIX/SOCK_STREAM|SEQPACKET is out of scope of my work. | |
| sys/kern/uipc_usrreq.c | ||
|---|---|---|
| 1103 | Fair enough! | |