dummynet: do not store struct ifnet pointers
ClosedPublic
Actions

Authored by kp on May 19 2022, 5:00 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG12c542cd0e9e: dummynet: do not store struct ifnet pointers

Summary

The dn_pkt_tag tag contained a struct ifnet pointer. If we persist that
across NET_EPOCH boundaries (as we did in dummynet) we risk panics if
the interface is removed between the packet being enqueued and it being
dequeued.

Convert the pointer into an index/generation pair and restore it when
the packet is taken out of the queue.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45633
Build 42521: arc lint + arc unit

Event Timeline

kp created this revision.May 19 2022, 5:00 PM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptMay 19 2022, 5:00 PM

kp requested review of this revision.May 19 2022, 5:00 PM

Harbormaster completed remote builds in B45633: Diff 106167.May 19 2022, 5:00 PM

kp added a child revision: D35257: pf: call dummynet directly from the ethernet code.May 19 2022, 5:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2022, 12:51 PM

Closed by commit rG12c542cd0e9e: dummynet: do not store struct ifnet pointers (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG12c542cd0e9e: dummynet: do not store struct ifnet pointers.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_dn_io.c

10 lines

ip_dn_private.h

3 lines

Diff 106167

View Options

sys/netpfil/ipfw/ip_dn_io.c