Details
- Reviewers
pauamma_gundo.com dbaio - Group Reviewers
docs - Commits
- R9:7a8025c4ffe5: committers-guide: fix the Phabricator wiki page address
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
LGTM (as I mentioned on the pull request), but I suggest adding docs as a group reviewer and mentioning a test plan. (Can be as simple as checking with igor and building. See https://docs.freebsd.org/en/books/fdp-primer/doc-build/.)
Is that, Igor the person? (I don't recognise the name, although it's recognised by Phabricator.)
No, the documentation linter installed as a docproj dependency.
[pauamma@gadfly] ~% pkg search igor
igor-1.595 FreeBSD Documentation Project sanity check script
...
[pauamma@gadfly] ~% pkg search docproj
docproj-4.1.1 Meta-port for the FreeBSD Documentation Project
...
In D35224#799716, @pauamma_gundo.com wrote:
No, the documentation linter installed as a docproj dependency.
Ah, thank you!
I made the mistake of seeking igor in https://docs.freebsd.org/en/books/fdp-primer/doc-build/ – not found.
Sought and found after switching from short (split) to long HTML https://docs.freebsd.org/en/books/fdp-primer/book/.
I do already have both packages, but the name igor was not memorable.