Page MenuHomeFreeBSD

sysvsem: Add a timeout argument to the semop.
ClosedPublic

Authored by dchagin on May 4 2022, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 4:05 AM
Unknown Object (File)
Thu, Jan 23, 11:04 AM
Unknown Object (File)
Thu, Jan 23, 10:50 AM
Unknown Object (File)
Wed, Jan 22, 10:00 AM
Unknown Object (File)
Tue, Jan 21, 2:23 AM
Unknown Object (File)
Mon, Jan 20, 11:54 PM
Unknown Object (File)
Mon, Jan 20, 10:40 PM
Unknown Object (File)
Dec 14 2024, 2:53 PM
Subscribers

Details

Summary

For future use in the Linux emulation layer for the semtimedop syscall
split the sys_semop syscall into two counterparts and add
struct timespec *timeout argument to the last one.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb added inline comments.
sys/kern/sysv_sem.c
1351–1352

I think this is fine, but I would maybe write this bit instead as something like:

if (error != 0) {
   if (error == ERESTART)
       error = EINTR;
   goto done2;
}

I think that makes the intent clearer overall.

This revision is now accepted and ready to land.May 4 2022, 6:40 PM
sys/kern/sysv_sem.c
1156

There is very similar, if not identical code, both in your recent kern_sig.c changes, and in kern_event.c::kqueue_scan(). Can it be extracted into some common helper? Also it arguably requires a comment so that people easily see how we handle timeout precision.

sys/kern/sysv_sem.c
1156

Yes, the code is almost identical, I already thought about what you suggested. I'll do it a bit later, first I need to commit my local queue, it's too big.

1351–1352

sure