Page MenuHomeFreeBSD

fusefs: use fsname mount option if set
ClosedPublic

Authored by ali.abdallah_suse.com on Apr 28 2022, 7:53 AM.
Tags
None
Referenced Files
F102756926: D35090.diff
Sat, Nov 16, 5:58 PM
Unknown Object (File)
Thu, Nov 14, 6:06 PM
Unknown Object (File)
Thu, Nov 7, 3:36 PM
Unknown Object (File)
Tue, Nov 5, 3:48 AM
Unknown Object (File)
Fri, Oct 25, 4:41 AM
Unknown Object (File)
Oct 2 2024, 8:43 AM
Unknown Object (File)
Oct 2 2024, 1:11 AM
Unknown Object (File)
Sep 30 2024, 5:26 PM
Subscribers
Restricted Owners Package

Details

Reviewers
asomers
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rG2737e6bca78c: fusefs: use the fsname mount option if set
rG2f6362484c0e: fusefs: use the fsname mount option if set
Summary

Use fsname if it set as f_mntfromname, this improves the output of df -hT, which will become

/dev/da0s1 fusefs 58G 814M 57G 1% /media/extfat
instead of
/dev/fuse fusefs 58G 814M 57G 1% /media/extfat

This requires no changes to existing fuse-libs based filesystem or other fuse fs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Use vfs_getopt instead of vfs_getopts

Does anything already set fsname? libfuse, perhaps?

Does anything already set fsname? libfuse, perhaps?

Yes, libfuse calls mount_fusefs on FreeBSD with fsname set, expect that it is currently ignored by mount_fusefs.

Enabling it in mount_fusefs, and optionally set it as f_mntfromname if it exists in the fuse kernel driver works with no issue for me.

Use specific m_flag for fsname= mount option field.

LGTM, and it works out of the box with at least one file system in ports.

This revision is now accepted and ready to land.Apr 29 2022, 4:53 PM
This revision was automatically updated to reflect the committed changes.