Differential D35081

pbio: Add locking and remove D_NEEDGIANT.
ClosedPublic
Actions

Authored by jhb on Apr 27 2022, 3:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 6:34 PM

	Unknown Object (File)
	Sat, Sep 14, 7:00 PM

	Unknown Object (File)
	Sun, Sep 8, 6:00 PM

	Unknown Object (File)
	Sat, Sep 7, 7:16 AM

	Unknown Object (File)
	Sat, Sep 7, 5:23 AM

	Unknown Object (File)
	Wed, Sep 4, 9:36 PM

	Unknown Object (File)
	Aug 30 2024, 8:14 AM

	Unknown Object (File)
	Jul 26 2024, 1:58 AM

View All 29 Files

Subscribers

None

Details

Reviewers

Commits

rG80893ea32be0: pbio: Add locking and remove D_NEEDGIANT.
rG51f481235c29: pbio: Add locking and remove D_NEEDGIANT.

Summary

Use a sx lock to permit uiomove directly into/out of the the per-port
buffers. In addition, the sx lock provides a stronger guarantee that
I think this driver wants which is to single-thread read and write
calls even while paused. Finally, replace tsleep with dummy wait
channels with calls to pause_sig to more clearly communicate the
intent.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 27 2022, 3:41 PM

jhb created this revision.

jhb added a parent revision: D35080: pbio: Return BUS_PROBE_DEFAULT from probe instead of 0..

Harbormaster completed remote builds in B45396: Diff 105470.Apr 27 2022, 3:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 11:44 PM

Closed by commit rG51f481235c29: pbio: Add locking and remove D_NEEDGIANT. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG51f481235c29: pbio: Add locking and remove D_NEEDGIANT..

jhb added a commit: rG80893ea32be0: pbio: Add locking and remove D_NEEDGIANT..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pbio/

54 lines

Diff 105729

sys/dev/pbio/pbio.c

Loading...