Page MenuHomeFreeBSD
Differential D35033

bsdinstall/partedit: fix UFS auto partitioning
ClosedPublic
Actions

Authored by asiciliano on Apr 23 2022, 5:25 AM.
Tags
None
Referenced Files
F102746203: D35033.diff
Sat, Nov 16, 3:40 PM
Unknown Object (File)
Sun, Oct 20, 8:22 AM
Unknown Object (File)
Sun, Oct 20, 8:21 AM
Unknown Object (File)
Sun, Oct 20, 8:21 AM
Unknown Object (File)
Sun, Oct 20, 8:21 AM
Unknown Object (File)
Sun, Oct 20, 7:59 AM
Unknown Object (File)
Sun, Oct 20, 7:59 AM
Unknown Object (File)
Oct 3 2024, 11:45 AM
View All 59 Files
Subscribers
imp
pstef

Details

Reviewers
bapt
nwhitehorn
Commits
rG9b4c606b96ce: bsdinstall/partedit: Fix UFS auto partitioning
Summary

Fix bsdinstall "Auto (UFS) Guided Disk Setup" and sade(8) "Auto" button.

Probably this should solve: https://lists.freebsd.org/archives/freebsd-current/2022-April/001851.html
I had a different error message during installation (bsdinstall/partedit) and a segmentation fault with sade locally.
Problem causes: 1) dialog does not differentiate between form.init and form.value, 2) dialog always allocates memory for the value while bsddialog only when a key is pressed.

Test Plan

I created 2 disks in virtualbox: the first to install the OS and the second to test [Auto] button.

good1.png (442×720 px, 14 KB)

googd2.png (442×720 px, 14 KB)

good3.png (442×720 px, 15 KB)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

asiciliano created this revision.Apr 23 2022, 5:25 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 23 2022, 5:25 AM
asiciliano requested review of this revision.Apr 23 2022, 5:25 AM
pstef added a subscriber: pstef.Apr 23 2022, 8:40 AM

Minor nit.

usr.sbin/bsdinstall/partedit/gpart_ops.c
1162

Isn't indentation wrong here?

asiciliano updated this revision to Diff 105341.Apr 23 2022, 12:34 PM
asiciliano edited the summary of this revision. (Show Details)
asiciliano edited the test plan for this revision. (Show Details)

Fixed, thank you.

asiciliano marked an inline comment as done.Apr 23 2022, 12:34 PM
asiciliano added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1162

fixed, thank you.

asiciliano edited the test plan for this revision. (Show Details)Apr 23 2022, 2:59 PM
asiciliano added a reviewer: nwhitehorn.
bapt accepted this revision.Apr 29 2022, 4:49 PM
This revision is now accepted and ready to land.Apr 29 2022, 4:49 PM
Closed by commit rG9b4c606b96ce: bsdinstall/partedit: Fix UFS auto partitioning (authored by asiciliano). · Explain WhyApr 29 2022, 11:25 PM
This revision was automatically updated to reflect the committed changes.
asiciliano marked an inline comment as done.
asiciliano added a commit: rG9b4c606b96ce: bsdinstall/partedit: Fix UFS auto partitioning.

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
partedit/
6 lines

Diff 105337

View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...