Page MenuHomeFreeBSD

Install working pkgconfig .pc files for compat libraries
ClosedPublic

Authored by arichardson on Apr 17 2022, 7:22 PM.
Tags
None
Referenced Files
F97594689: D34939.diff
Mon, Sep 30, 6:18 AM
Unknown Object (File)
Sat, Sep 21, 9:43 PM
Unknown Object (File)
Mon, Sep 9, 12:41 PM
Unknown Object (File)
Wed, Sep 4, 10:24 PM
Unknown Object (File)
Mon, Sep 2, 12:09 PM
Unknown Object (File)
Aug 22 2024, 5:45 PM
Unknown Object (File)
Aug 13 2024, 12:08 PM
Unknown Object (File)
Aug 6 2024, 10:08 AM
Subscribers

Details

Summary

Instead of installing them to /usr/libdata/pkgconfig, we use
/usr/lib<suffix>/pkgconfig. I'm not sure why native ABI libdirs are
installed to /usr/libdata/pkgconfig instead of /usr/lib/pkgconfig, but
I don't think this commit should change that.

Test Plan

grep -rn libdir= ./usr/lib32/pkgconfig/*.pc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Use FreeBSD HEAD instead of CheriBSD HEAD as the base

arichardson edited the test plan for this revision. (Show Details)
In D34939#792003, @imp wrote:

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Thanks, yes that is what I was looking for before updating the review :)

It's a pitty we can't be consistent and have a libdata equivalent for compat libraries, but on the other hand I don't have better proposal that what is proposed here.

If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 10:47 PM
This revision was automatically updated to reflect the committed changes.