Page MenuHomeFreeBSD

cxgbetool(8): User interface to round-robin queue selection via COP.
ClosedPublic

Authored by np on Apr 14 2022, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 8:36 PM
Unknown Object (File)
Sun, Nov 3, 8:36 PM
Unknown Object (File)
Sun, Nov 3, 8:36 PM
Unknown Object (File)
Sun, Nov 3, 8:26 PM
Unknown Object (File)
Tue, Oct 22, 8:09 AM
Unknown Object (File)
Oct 5 2024, 12:54 PM
Unknown Object (File)
Sep 30 2024, 9:33 PM
Unknown Object (File)
Sep 27 2024, 7:41 AM
Subscribers

Details

Summary

Queue "roundrobin" in a COP rule means the driver should select queues
for new tids in a round-robin manner.

MFC after: 1 week
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb added inline comments.
usr.sbin/cxgbetool/cxgbetool.c
3153–3157

Perhaps in general we might consider using strcasecmp? I also tend to prefer an idiom of strcmp() == 0 or strcmp() != 0 as the operator matches the logic of the expression, but the existing code uses the !strcmp pattern so the current patch is fine.

This revision is now accepted and ready to land.Apr 14 2022, 10:51 PM