Page MenuHomeFreeBSD

vm: Move the "vm_wait in early boot" assertion to the proper place
ClosedPublic

Authored by markj on Apr 14 2022, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 12:44 AM
Unknown Object (File)
Oct 6 2024, 10:21 PM
Unknown Object (File)
Sep 25 2024, 4:09 PM
Unknown Object (File)
Sep 25 2024, 4:09 PM
Unknown Object (File)
Sep 25 2024, 4:09 PM
Unknown Object (File)
Sep 25 2024, 3:54 PM
Unknown Object (File)
Sep 24 2024, 9:12 AM
Unknown Object (File)
Sep 24 2024, 4:19 AM
Subscribers

Details

Summary

The assertion was added in commit 1771e987ca6a. After that, vm_wait()
and friends were refactored such that the actual sleep happens
elsewhere. Now the assertion condition is not checked when
vm_wait_doms() is called directly, and it is checked even if we are not
going to sleep (because vm_page_count_min_set(wdoms) is false).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Apr 14 2022, 1:21 PM
This revision is now accepted and ready to land.Apr 14 2022, 2:29 PM
alc added inline comments.
sys/vm/vm_page.c
3243

As an aside, this variable seems pointless. Each of the 3 cases could end in a return statement.