Paths

Table of Contentst

Differential D34708

linux(4): Add compat.linux32.true_i386_emulation knob.
ClosedPublic
Actions

Authored by dchagin on Mar 29 2022, 4:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 30, 12:03 PM

	Unknown Object (File)
	Oct 9 2024, 9:07 PM

	Unknown Object (File)
	Oct 2 2024, 9:31 PM

	Unknown Object (File)
	Oct 2 2024, 12:10 PM

	Unknown Object (File)
	Oct 1 2024, 3:18 PM

	Unknown Object (File)
	Sep 30 2024, 4:33 AM

	Unknown Object (File)
	Sep 24 2024, 6:14 AM

	Unknown Object (File)
	Sep 23 2024, 4:09 PM

View All 73 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

pauamma_gundo.com
emaste

Group Reviewers

manpages
Linux Emulation

Commits

rG82fa7c3b83d8: linux(4): Add compat.linux32.emulate_i386 knob.
rGd5dc757e84d8: linux(4): Add compat.linux32.emulate_i386 knob.

Summary

Historically 32-bit Linuxulator under amd64 emulated the real i386
behaviour. Since 3d8dd983 the old i386 Linux world can't be used under
amd64 Linuxulator as it don't know anything about amd64 machine (which
is returned now by newuname Lunuxulator syscall). So, add a knob to
allow nice guys like me swith the behaviour and use i386 Linux binaries
on amd64.
Set knob to the new behaviour as I think this is common to the modern
Linux distros.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44934
Build 41822: arc lint + arc unit

Event Timeline

dchagin created this revision.Mar 29 2022, 4:52 PM

Herald added a reviewer: manpages. · View Herald TranscriptMar 29 2022, 4:52 PM

Herald added a subscriber: imp. · View Herald Transcript

dchagin requested review of this revision.Mar 29 2022, 4:52 PM

Harbormaster completed remote builds in B44918: Diff 104335.Mar 29 2022, 4:52 PM

dchagin added a reviewer: Linux Emulation.Mar 29 2022, 4:54 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

emaste added a subscriber: emaste.Mar 29 2022, 5:04 PM

emaste added inline comments.

share/man/man4/linux.4
151	typo, binary

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 29 2022, 5:06 PM

pauamma_gundo.com added inline comments.

share/man/man4/linux.4
149–151	Spelling, some tweaks to wording for clarity, line breaks between sentences.

fixed manual, thank you

Harbormaster completed remote builds in B44919: Diff 104336.Mar 29 2022, 5:24 PM

Manual page English and markup LGTM. Can't speak for source code or consistency with it.

This revision is now accepted and ready to land.Mar 29 2022, 5:32 PM

Not a strong objection but I think the name true_i386_emulation is a bit strange. Maybe just drop "true", or "emulate_i386" or "emulate_32bit"?

aha, agree, fixed, thanks Ed

This revision now requires review to proceed.Mar 31 2022, 12:06 PM

Harbormaster completed remote builds in B44934: Diff 104404.Mar 31 2022, 12:06 PM

emaste accepted this revision.Mar 31 2022, 12:47 PM

This revision is now accepted and ready to land.Mar 31 2022, 12:47 PM

Closed by commit rGd5dc757e84d8: linux(4): Add compat.linux32.emulate_i386 knob. (authored by dchagin). · Explain WhyMar 31 2022, 6:02 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGd5dc757e84d8: linux(4): Add compat.linux32.emulate_i386 knob..

dchagin added a commit: rG82fa7c3b83d8: linux(4): Add compat.linux32.emulate_i386 knob..Jun 17 2022, 7:42 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

6 lines

sys/

amd64/

linux32/

2 lines

linux32_sysvec.c

3 lines

compat/

linux/

5 lines

Diff 104404

share/man/man4/linux.4

Loading...

sys/amd64/linux32/linux.h

Loading...

sys/amd64/linux32/linux32_sysvec.c

Loading...

sys/compat/linux/linux_misc.c

Loading...