Page MenuHomeFreeBSD
Differential D34612

mixer(8): add shorthand syntax for setting the volume
ClosedPublic
Actions

Authored by christos on Mar 20 2022, 4:05 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Nov 16, 9:48 PM
Unknown Object (File)
Fri, Nov 15, 7:53 AM
Unknown Object (File)
Tue, Nov 5, 7:01 PM
Unknown Object (File)
Fri, Nov 1, 6:26 AM
Unknown Object (File)
Wed, Oct 30, 1:28 AM
Unknown Object (File)
Tue, Oct 29, 8:00 PM
Unknown Object (File)
Sun, Oct 27, 12:22 AM
Unknown Object (File)
Oct 4 2024, 5:21 AM
View All 66 Files
Subscribers
imp

Details

Reviewers
• hselasky
Commits
rGda3d4469ef84: mixer(8): Add shorthand syntax for setting the volume.
Summary

dev.volume=X can now also be written as dev=X.
Requested by hselasky@ and bsduck on a forum conversation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

christos created this revision.Mar 20 2022, 4:05 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 20 2022, 4:05 PM
christos requested review of this revision.Mar 20 2022, 4:05 PM
christos added a parent revision: D34591: mixer(8): remove [.volume] string from default printout.
christos mentioned this in D34591: mixer(8): remove [.volume] string from default printout.Mar 20 2022, 4:07 PM
• hselasky added inline comments.Mar 20 2022, 4:12 PM
usr.sbin/mixer/mixer.c
150

Should this loop also check for "." characters, so that you can either do:

dev=80 or dev = 0.80 ?

--HPS

christos added inline comments.Mar 20 2022, 4:13 PM
usr.sbin/mixer/mixer.c
150

It should. I totally forgot about that. My bad :-)

christos updated this revision to Diff 104029.Mar 20 2022, 4:21 PM

Accept floating point numbers as input.

christos marked an inline comment as done.Mar 20 2022, 4:21 PM
• hselasky accepted this revision.Mar 20 2022, 4:24 PM
This revision is now accepted and ready to land.Mar 20 2022, 4:24 PM
christos added a child revision: D34613: mixer(8): move control defines into an enum.Mar 20 2022, 4:27 PM
christos added a comment.Mar 20 2022, 4:32 PM

Don't push it. I also forgot to add suport for [+|-].

Closed by commit rGda3d4469ef84: mixer(8): Add shorthand syntax for setting the volume. (authored by • hselasky). · Explain WhyMar 20 2022, 4:34 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rGda3d4469ef84: mixer(8): Add shorthand syntax for setting the volume..

Revision Contents
Changeset List

PathSize
usr.sbin/
mixer/
28 lines

Diff 104028

View Options

usr.sbin/mixer/mixer.c

Loading...