Page MenuHomeFreeBSD

bectl: push space-in-name check down into libbe
ClosedPublic

Authored by kevans on Mar 18 2022, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 2:39 AM
Unknown Object (File)
Nov 19 2024, 3:17 AM
Unknown Object (File)
Nov 19 2024, 2:52 AM
Unknown Object (File)
Nov 19 2024, 12:56 AM
Unknown Object (File)
Nov 6 2024, 4:44 PM
Unknown Object (File)
Oct 30 2024, 11:55 PM
Unknown Object (File)
Oct 1 2024, 3:48 PM
Unknown Object (File)
Oct 1 2024, 3:47 PM
Subscribers

Details

Summary
bectl: push space-in-name check down into libbe

This check was previously in `create` only, not applying to renames.  It
should really be applied at the libbe level, so that we can avoid
writing about this restriction over and over again.

While we're here: `bectl rename` always succeeds, even when it doesn't.
Start returning the error.

Reported By:    Christian McDonald <cmcdonald netgate com>
Differential Revision:  https://reviews.freebsd.org/D34605

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44822
Build 41710: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 18 2022, 6:18 PM
kevans retitled this revision from bectl: disallow names with spaces in `rename` command to bectl: push space-in-name check down into libbe.
kevans edited the summary of this revision. (Show Details)

Reverse course, push the naming restriction into libbe as well for others' benefit (suggested by Christian).

This revision now requires review to proceed.Mar 31 2022, 10:56 PM
This revision is now accepted and ready to land.Apr 1 2022, 4:05 AM