*: Do not the no-op -r flag for bsdlabel(8)
ClosedPublic
Actions

Authored by 0mp on Mar 17 2022, 10:24 AM.

Details

Reviewers

phk
imp

Group Reviewers

manpages

Commits

rG386fdd971d84: *: Do not use the no-op -r flag for bsdlabel(8)
rG30a1d38e6cbd: *: Do not use the no-op -r flag for bsdlabel(8)
rGfd061175257a: *: Do not use the no-op -r flag for bsdlabel(8)

Summary

The -r flag is ignored by the FreeBSD implementation of bsdlabel(8)
(also called disklabel(8) in the past). Remove its use from examples
and tests in the tree.

This commit does not touch historical documentation under share/doc/smm
and files under contrib/netbsd-tests.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Mar 17 2022, 10:24 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 17 2022, 10:24 AM

Herald added a subscriber: imp. · View Herald Transcript

0mp requested review of this revision.Mar 17 2022, 10:24 AM

Harbormaster completed remote builds in B44805: Diff 103937.Mar 17 2022, 10:24 AM

s/Not the/Note the/ in the subject.
This flag lost all meaning with the geom rewrite that phk did, so maybe note that... So 4.x time frame, 20-odd years ago.

This revision is now accepted and ready to land.Mar 17 2022, 4:19 PM

In D34585#783648, @imp wrote:

s/Not the/Note the/ in the subject.
This flag lost all meaning with the geom rewrite that phk did, so maybe note that... So 4.x time frame, 20-odd years ago.

Ah, yes, I missed a part of the subject. I'll fix that for the final commit.

I agree that it'd be nice to document that this flag is a no-op. I'll see if I can find a moment to do it.

Thanks, @imp!

Closed by commit rGfd061175257a: *: Do not use the no-op -r flag for bsdlabel(8) (authored by 0mp). · Explain WhyMar 17 2022, 4:32 PM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rGfd061175257a: *: Do not use the no-op -r flag for bsdlabel(8).

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 17 2022, 9:58 PM

pauamma_gundo.com added inline comments.