Page MenuHomeFreeBSD
Differential D34515

df: do not report a 100% full inode usage on fs without inodes
ClosedPublic
Actions

Authored by bapt on Mar 10 2022, 2:31 PM.
Tags
None
Referenced Files
F102868950: D34515.diff
Mon, Nov 18, 5:30 AM
Unknown Object (File)
Oct 16 2024, 1:54 PM
Unknown Object (File)
Oct 16 2024, 1:54 PM
Unknown Object (File)
Oct 16 2024, 1:54 PM
Unknown Object (File)
Oct 16 2024, 1:32 PM
Unknown Object (File)
Sep 20 2024, 10:41 AM
Unknown Object (File)
Sep 20 2024, 2:04 AM
Unknown Object (File)
Sep 19 2024, 3:06 PM
View All 58 Files
Subscribers
imp

Details

Reviewers
emaste
manu
kevans
imp
Commits
rG1a566dd6a480: df: do not report a 100% full inode usage on fs without inodes
rG2eee44bd5ebc: df: do not report a 100% full inode usage on fs without inodes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44730
Build 41618: arc lint + arc unit

Event Timeline

bapt created this revision.Mar 10 2022, 2:31 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 10 2022, 2:31 PM
bapt requested review of this revision.Mar 10 2022, 2:31 PM
Harbormaster completed remote builds in B44730: Diff 103719.Mar 10 2022, 2:31 PM
bapt added a comment.Mar 10 2022, 2:32 PM

before:

$ df -i /dev
devfs                       2        2         0   100%       0          0   100%   /dev

after:

$ df -i /dev
devfs                       2        2         0   100%       0          0      -   /dev
bapt added a reviewer: manu.Mar 10 2022, 2:33 PM

it avoids monitoring tools which look for inode occupation to have to maintain of list of filesystem to skip.

Note that on linux df is doring the same, for example on msdosfs filesystem.

manu accepted this revision.Mar 10 2022, 2:34 PM

make sense to me.

This revision is now accepted and ready to land.Mar 10 2022, 2:34 PM
bapt added a reviewer: kevans.Mar 10 2022, 2:49 PM
emaste accepted this revision.Mar 10 2022, 3:10 PM

Seems reasonable to me. Perhaps we should note it in the man page?

imp accepted this revision.Mar 10 2022, 3:58 PM
In D34515#782020, @emaste wrote:

Seems reasonable to me. Perhaps we should note it in the man page?

+1

Closed by commit rG2eee44bd5ebc: df: do not report a 100% full inode usage on fs without inodes (authored by bapt). · Explain WhyMar 11 2022, 7:50 AM
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rG2eee44bd5ebc: df: do not report a 100% full inode usage on fs without inodes.
bapt added a commit: rG1a566dd6a480: df: do not report a 100% full inode usage on fs without inodes.Oct 12 2022, 9:21 AM

Revision Contents
Changeset List

PathSize
bin/
df/
9 lines

Diff 103719

View Options

bin/df/df.c

Loading...