Page MenuHomeFreeBSD
Differential D34514

rc: Use startmsg instead of echo on start messages
ClosedPublic
Actions

Authored by jlduran on Mar 10 2022, 12:38 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:47 AM
Unknown Object (File)
Oct 15 2024, 4:39 PM
Unknown Object (File)
Oct 9 2024, 2:20 PM
Unknown Object (File)
Oct 9 2024, 2:20 PM
Unknown Object (File)
Oct 9 2024, 2:20 PM
Unknown Object (File)
Oct 9 2024, 2:03 PM
Unknown Object (File)
Oct 9 2024, 2:02 PM
Unknown Object (File)
Oct 4 2024, 5:49 PM
View All 46 Files
Subscribers
imp

Details

Reviewers
imp
0mp
Group Reviewers
Contributor Reviews (src)
rc
Commits
rGe8396a9592ab: rc.d/*: Use startmsg instead of echo on start messages
rG8f2bb173bfc6: Introduce startmsg and use it in rc scripts
rG19a6267d61a0: rc.d/*: Use startmsg instead of echo on start messages
rG325ebf37d8ef: Introduce startmsg and use it in rc scripts
Summary

By rc.conf(5), setting rc_startmsgs="NO" should silence start messages.

Fix a few rc scripts by using startmsg.

PR: 255207

Test Plan

sysrc rc_startmsgs=NO
shutdown -r now

No Starting... messages should be displayed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Mar 10 2022, 12:38 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 10 2022, 12:38 AM
jlduran requested review of this revision.Mar 10 2022, 12:38 AM
jlduran added a parent revision: D34513: rc.subr: Introduce startmsg.
jlduran edited the summary of this revision. (Show Details)Mar 10 2022, 10:46 AM
jlduran edited the test plan for this revision. (Show Details)
imp accepted this revision.Mar 10 2022, 3:51 PM

this looks good to me. I don't know if it solves all the problems in this area, but it looks to be a good improvement at the very least.

This revision is now accepted and ready to land.Mar 10 2022, 3:51 PM
jlduran added a comment.Mar 10 2022, 4:47 PM

Thank you. I’ll add a brief mention to it in rc.subr(8).

0mp accepted this revision.Mar 13 2022, 5:55 PM
Closed by commit rG325ebf37d8ef: Introduce startmsg and use it in rc scripts (authored by jlduran, committed by 0mp). · Explain WhyMar 13 2022, 5:58 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG325ebf37d8ef: Introduce startmsg and use it in rc scripts.
0mp added a commit: rG19a6267d61a0: rc.d/*: Use startmsg instead of echo on start messages.
0mp added a commit: rG8f2bb173bfc6: Introduce startmsg and use it in rc scripts.Feb 22 2023, 12:29 PM
0mp added a commit: rGe8396a9592ab: rc.d/*: Use startmsg instead of echo on start messages.

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
2 lines
4 lines
4 lines
4 lines
4 lines
5 lines
4 lines
4 lines
4 lines
4 lines
3 lines
4 lines
4 lines
2 lines
11 lines
share/
man/
man8/
15 lines

Diff 103808

View Options

libexec/rc/rc.d/bgfsck

Loading...
View Options

libexec/rc/rc.d/cleartmp

Loading...
View Options

libexec/rc/rc.d/fsck

Loading...
View Options

libexec/rc/rc.d/hostid

Loading...
View Options

libexec/rc/rc.d/hostname

Loading...
View Options

libexec/rc/rc.d/ldconfig

Loading...
View Options

libexec/rc/rc.d/motd

Loading...
View Options

libexec/rc/rc.d/mountcritlocal

Loading...
View Options

libexec/rc/rc.d/moused

Loading...
View Options

libexec/rc/rc.d/newsyslog

Loading...
View Options

libexec/rc/rc.d/nfsclient

Loading...
View Options

libexec/rc/rc.d/os-release

Loading...
View Options

libexec/rc/rc.d/pf

Loading...
View Options

libexec/rc/rc.d/savecore

Loading...
View Options

libexec/rc/rc.subr

Loading...
View Options

share/man/man8/rc.subr.8

Loading...