Page MenuHomeFreeBSD
Differential D34415

ddb: Add 'show gic <name>' and 'show all gics' commands.
ClosedPublic
Actions

Authored by jhb on Mar 2 2022, 11:00 PM.
Tags
None
Referenced Files
F103056039: D34415.id103737.diff
Wed, Nov 20, 8:53 AM
Unknown Object (File)
Oct 3 2024, 9:19 AM
Unknown Object (File)
Oct 3 2024, 6:29 AM
Unknown Object (File)
Sep 16 2024, 12:30 PM
Unknown Object (File)
Sep 6 2024, 6:59 PM
Unknown Object (File)
Sep 4 2024, 11:57 AM
Unknown Object (File)
Sep 2 2024, 1:43 PM
Unknown Object (File)
Aug 8 2024, 8:04 PM
View All 34 Files
Subscribers
jrtc27

Details

Reviewers
manu
imp
andrew
Commits
rG904a13759cf6: ddb: Add 'show gic <name>' and 'show all gics' commands.
Summary

To handle the different register layouts for different versions, add a
GIC_DB_SHOW() method. Currently this hook is only implemented for
versions 1 and 2.

Sponsored by: University of Cambridge, Google, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Mar 2 2022, 11:00 PM
jhb created this revision.
Harbormaster completed remote builds in B44619: Diff 103419.Mar 2 2022, 11:00 PM
jhb added a comment.Mar 2 2022, 11:06 PM

Note that I did not implement this for GIC version 3 (left as an exercise to the reader). This was possibly useful debugging an issue with a 32-bit ARM core on an FPGA running FreeBSD. I also tested this to at least make sure the output was sane in QEMU.

db> show gic gic0
gic0 CPU registers:
 CTLR: 00000001   PMR: 000000ff   BPR: 00000007   RPR: 000000ff
HPPIR: 0000001b  IIDR: 00000000
gic0 Distributor registers:
 CTLR: 00000001 TYPER: 00000008  IIDR: 00000000
SGI  0  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  1  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  2  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  3  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  4  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  5  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  6  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  7  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  8  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI  9  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 10  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 11  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 12  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 13  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 14  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
SGI 15  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO ED
PPI  0  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  1  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  2  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  3  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  4  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  5  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  6  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  7  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO LV
PPI  8  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI  9  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI 10  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI 11  grp:0 enable:1 pend:1 active:0 pri:0 trg:0 LO LV
PPI 12  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI 13  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI 14  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
PPI 15  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  0  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  1  grp:0 enable:1 pend:0 active:0 pri:0 trg:0 LO LV
SPI  2  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  3  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  4  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  5  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  6  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  7  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  8  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI  9  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI 10  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI 11  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI 12  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI 13  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
SPI 14  grp:0 enable:0 pend:0 active:0 pri:0 trg:0 LO LV
...
jrtc27 added a subscriber: jrtc27.Mar 9 2022, 6:25 PM
jrtc27 added inline comments.
sys/arm/arm/gic.c
1188–1194

Precedence is the right way round for >> and binary * but for me this is one of the cases that I always need to look up, so maybe best to add the redundant clarifying parentheses?

sys/arm/arm/gic_if.m
71

Should this be guarded by ifdef DDB too (with all the CODE/HEADER gunk that requires)?

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2022, 11:41 PM
Closed by commit rG904a13759cf6: ddb: Add 'show gic <name>' and 'show all gics' commands. (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG904a13759cf6: ddb: Add 'show gic <name>' and 'show all gics' commands..
jhb added inline comments.Mar 11 2022, 2:07 AM
sys/arm/arm/gic_if.m
71

(Oops, missed your review). I don't think we need the gunk just for the interface. It only costs a single global var in the foo_if.c file.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
109 lines
4 lines

Diff 103737

View Options

sys/arm/arm/gic.c

Loading...
View Options

sys/arm/arm/gic_if.m

Loading...