Reported by: GCC -Wparantheses
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/compat/linuxkpi/common/src/linux_xarray.c | ||
---|---|---|
106 | I kept the '!= 0' only because that is the preferred FreeBSD style. Note that one could rewrite this assertion as: if ((xa->flags & XA_FLAGS_ALLOC1) != 0) MPASS(mask > 1); Not sure if that would be more readable? |
sys/compat/linuxkpi/common/src/linux_xarray.c | ||
---|---|---|
106 | We also want to assert mask > 0 for xa->flags & XA_FLAGS_ALLOC1 == 0 though do we not? |
sys/compat/linuxkpi/common/src/linux_xarray.c | ||
---|---|---|
106 | Hmmm, I had misread as it as being tautological (>= 0). |