xlocale.c: check for allocation failure
ClosedPublic
Actions

Authored by kib on Feb 2 2022, 5:35 PM.

Details

Reviewers

emaste
markj

Commits

rGef061a2e2978: __ctype_load(): check for calloc() failure
rG87151b60e069: __numeric_load(): check for calloc() failure
rG1aa669c5f9c2: libc/locale/lnumeric.c: minor style
rG4d3b84f67c2e: __monetary_load(): check for calloc() failure
rG0fed1e6f1831: libc/locale/lmonetary.c: minor style
rGbc9ce839f981: __messages_load(): check for calloc() failure
rG5b7e92d48fbc: libc/locale/lmessages.c: minor style
rGb8ad908ad98a: __collate_load(): check for calloc failure
rGa8be0611674e: libc/locale/collate.c: minor style
rG7bf532c9d447: xlocale.c: only call init_key() when locale was successfully allocated
rGb68522308d1e: xlocale.c: check for allocation failure
rGfcdf9d7de536: xlocale.c:init_key(): do not ignore errors from pthread_key_create()
rGaaa6fa65a6a0: libc/locale/xlocale.c: minor style

Summary

PR: 261679

Also

Style

xlocale.c: only call init_key() when locale was successfully allocated

xlocale.c:init_key(): do not ignore errors from pthread_key_create()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Feb 2 2022, 5:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2022, 5:35 PM

kib requested review of this revision.Feb 2 2022, 5:35 PM

All of the other calloc() calls in libc/locale/*.c have the same bug.

This revision is now accepted and ready to land.Feb 2 2022, 5:44 PM

Handle all calloc() invocations in locale/.

This revision now requires review to proceed.Feb 2 2022, 6:19 PM

markj accepted this revision.Feb 2 2022, 9:13 PM

This revision is now accepted and ready to land.Feb 2 2022, 9:13 PM

Closed by commit rGaaa6fa65a6a0: libc/locale/xlocale.c: minor style (authored by kib). · Explain WhyFeb 3 2022, 2:49 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGaaa6fa65a6a0: libc/locale/xlocale.c: minor style.

kib added a commit: rGfcdf9d7de536: xlocale.c:init_key(): do not ignore errors from pthread_key_create().

kib added a commit: rGb68522308d1e: xlocale.c: check for allocation failure.

kib added a commit: rG7bf532c9d447: xlocale.c: only call init_key() when locale was successfully allocated.

kib added a commit: rGa8be0611674e: libc/locale/collate.c: minor style.

kib added a commit: rGb8ad908ad98a: __collate_load(): check for calloc failure.

kib added a commit: rG5b7e92d48fbc: libc/locale/lmessages.c: minor style.

kib added a commit: rGbc9ce839f981: __messages_load(): check for calloc() failure.

kib added a commit: rG0fed1e6f1831: libc/locale/lmonetary.c: minor style.

kib added a commit: rG4d3b84f67c2e: __monetary_load(): check for calloc() failure.

kib added a commit: rG1aa669c5f9c2: libc/locale/lnumeric.c: minor style.

kib added a commit: rG87151b60e069: __numeric_load(): check for calloc() failure.

kib added a commit: rGef061a2e2978: __ctype_load(): check for calloc() failure.

Revision Contents
Changeset List

Path

Size

lib/

libc/

locale/

xlocale.c

30 lines

Diff 102287

View Options

xlocale.c: check for allocation failureClosedPublicActions