website: Get rid of tables for snapshots in where/
ClosedPublic
Actions

Authored by trasz on Feb 1 2022, 6:10 PM.

Details

Reviewers

Group Reviewers

docs
doceng
releng

Commits

R9:754da8344b84: website: Get rid of tables for snapshots in where/

Summary

Reduce the number of seemingly identical tables on the downloads
page by half by only providing them for release images. The utility
of those tables for snapshots was already questionable, with eg
differently individual links leading to the same target directory.

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 44233
Build 41121: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Feb 1 2022, 6:10 PM

trasz created this revision.

Harbormaster completed remote builds in B44230: Diff 102229.Feb 1 2022, 6:10 PM

Preview: https://people.freebsd.org/~trasz/D34134.html

Btw, it would be nice if we could provide a direct link to amd64 14-CURRENT memstick image, but the filenames contain git revisions, so it's a bit impractical. Perhaps we could have a symlink?

In D34134#771926, @trasz wrote:

Btw, it would be nice if we could provide a direct link to amd64 14-CURRENT memstick image, but the filenames contain git revisions, so it's a bit impractical. Perhaps we could have a symlink?

The download mirrors are already over-polluted with symlinks.

Go a bit further.

Harbormaster completed remote builds in B44233: Diff 102232.Feb 1 2022, 6:40 PM

In D34134#771931, @gjb wrote:

In D34134#771926, @trasz wrote:

Btw, it would be nice if we could provide a direct link to amd64 14-CURRENT memstick image, but the filenames contain git revisions, so it's a bit impractical. Perhaps we could have a symlink?

The download mirrors are already over-polluted with symlinks.

Then perhaps there is a way for the website tooling to generate different links based on the information provided in a plain text file (like https://download.freebsd.org/snapshots/amd64/amd64/14.0-CURRENT/REVISION)?

I prefer the previous/first patch you sent, with the titles.

It's clean, and the page emphasizes only releases, but CURRENT and STABLE have their spot.

For me, that looks good.

But let's wait for others.

Back to the first version.

Harbormaster completed remote builds in B44270: Diff 102318.Feb 3 2022, 1:35 PM

In D34134#771952, @dbaio wrote:

I prefer the previous/first patch you sent, with the titles.

It's clean, and the page emphasizes only releases, but CURRENT and STABLE have their spot.

For me, that looks good.

But let's wait for others.

I think I agree. I've updated the example to match the current version.

IMHO it looks good, but wait for releng review.

It's gonna be two weeks soon, can I assume a timeout for releng?

ygy added a reviewer: gjb.Feb 14 2022, 4:31 PM

gjb accepted this revision as: releng, gjb.Feb 14 2022, 5:27 PM

This revision is now accepted and ready to land.Feb 14 2022, 5:27 PM

I'm not sure about the vertical centering of shorter columns, but it's likely my preferences and not general. I asked in #freebsd if a screenreader user (I think there was one in channel for a while) could check table navigation, but unless one gives feedback within 24 hours, I'd go ahead.

Closed by commit R9:754da8344b84: website: Get rid of tables for snapshots in where/ (authored by trasz). · Explain WhyFeb 21 2022, 2:38 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: R9:754da8344b84: website: Get rid of tables for snapshots in where/.