dummynet: dn_dequeue() may return NULL
ClosedPublic
Actions

Authored by kp on Jan 28 2022, 11:10 AM.

Tags

None

Referenced Files

	F109417597: D34078.diff
	Tue, Feb 4, 7:30 PM

	Unknown Object (File)
	Tue, Jan 28, 2:23 AM

	Unknown Object (File)
	Mon, Jan 27, 2:06 PM

	Unknown Object (File)
	Sun, Jan 26, 10:56 AM

	Unknown Object (File)
	Thu, Jan 16, 11:29 PM

	Unknown Object (File)
	Tue, Jan 14, 7:06 AM

	Unknown Object (File)
	Dec 3 2024, 6:38 PM

	Unknown Object (File)
	Nov 6 2024, 3:13 PM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network
pfsense

Commits

rG9dac026822ab: dummynet: dn_dequeue() may return NULL

Summary

If there are no more entries, or if we fail to restore the rcvif of a
queued mbuf dn_dequeue() can return NULL.
Cope with this.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44142
Build 41030: arc lint + arc unit

Event Timeline

kp created this revision.Jan 28 2022, 11:10 AM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptJan 28 2022, 11:10 AM

kp requested review of this revision.Jan 28 2022, 11:10 AM

Harbormaster completed remote builds in B44142: Diff 102045.Jan 28 2022, 11:10 AM

glebius accepted this revision.Jan 28 2022, 5:28 PM

This revision is now accepted and ready to land.Jan 28 2022, 5:28 PM

Closed by commit rG9dac026822ab: dummynet: dn_dequeue() may return NULL (authored by kp). · Explain WhyJan 28 2022, 11:10 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG9dac026822ab: dummynet: dn_dequeue() may return NULL.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

dn_sched_wf2q.c

2 lines

Diff 102045

View Options

sys/netpfil/ipfw/dn_sched_wf2q.c

dummynet: dn_dequeue() may return NULLClosedPublicActions