Page MenuHomeFreeBSD

Tidying up all the conditionals, when a spurious RTO is unwound
ClosedPublic

Authored by rscheff on Jan 27 2022, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 4 2024, 3:06 AM
Unknown Object (File)
Sep 25 2024, 9:58 AM
Unknown Object (File)
Sep 25 2024, 3:38 AM
Unknown Object (File)
Sep 20 2024, 1:00 PM
Unknown Object (File)
Sep 16 2024, 6:14 PM
Unknown Object (File)
Aug 30 2024, 6:59 AM
Unknown Object (File)
Aug 30 2024, 6:59 AM
Unknown Object (File)
Aug 30 2024, 6:59 AM

Details

Summary

This is a split-off from D33979, where only an acute issue is addressed.

The below points were noted incidentially while addressing that TF_PREVVALID
must not, just by itself, be used as sole condition for restoring old TCP state.

  • Use the semantically correct TSTMP_xx macro when comparing timestamps. (No functional change)
  • check for bad retransmits only when TSopt is present in ACK (don't assume there will be a valid TSopt in the TCP options struct)
  • exclude tsecr == 0, since that most likely indicates an invalid ts echo return (tsecr) value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable