tcp: fix leaks in tcp_chg_pacing_rate error paths
ClosedPublic
Actions

Authored by gallatin on Jan 27 2022, 1:01 AM.

Tags

None

Referenced Files

	F116123634: D34058.diff
	Fri, May 2, 6:44 PM

	Unknown Object (File)
	Sat, Apr 19, 12:30 AM

	Unknown Object (File)
	Fri, Apr 18, 4:40 AM

	Unknown Object (File)
	Sat, Apr 12, 4:17 PM

	Unknown Object (File)
	Mar 31 2025, 8:11 PM

	Unknown Object (File)
	Mar 13 2025, 6:55 PM

	Unknown Object (File)
	Mar 13 2025, 5:38 PM

	Unknown Object (File)
	Feb 17 2025, 8:18 AM

Subscribers

Details

Reviewers

rrs
• hselasky
jhb

Group Reviewers

transport

Commits

rG8a7404b2aeeb: tcp: fix leaks in tcp_chg_pacing_rate error paths

Summary

tcp_chg_pacing_rate() is expected to release the hw rate limit table, but failed to do so in several error cases, leading to ever increasing counts of flows using the rate.

This patch was mostly done by @rrs

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

gallatin created this revision.Jan 27 2022, 1:01 AM

Herald added a reviewer: transport. · View Herald TranscriptJan 27 2022, 1:01 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

gallatin requested review of this revision.Jan 27 2022, 1:01 AM

Looks good.

rrs accepted this revision.Jan 27 2022, 8:34 AM

This revision is now accepted and ready to land.Jan 27 2022, 8:34 AM

Closed by commit rG8a7404b2aeeb: tcp: fix leaks in tcp_chg_pacing_rate error paths (authored by gallatin). · Explain WhyJan 27 2022, 3:43 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG8a7404b2aeeb: tcp: fix leaks in tcp_chg_pacing_rate error paths.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_ratelimit.c

21 lines

Diff 101972

View Options

sys/netinet/tcp_ratelimit.c

tcp: fix leaks in tcp_chg_pacing_rate error pathsClosedPublicActions