Page MenuHomeFreeBSD

Fix a memory leak when ip_output_send() returns EAGAIN due to send tag issues
ClosedPublic

Authored by gallatin on Jan 26 2022, 9:19 PM.
Tags
None
Referenced Files
F102048918: D34054.diff
Wed, Nov 6, 11:35 PM
Unknown Object (File)
Sep 10 2024, 7:04 AM
Unknown Object (File)
Sep 5 2024, 12:44 AM
Unknown Object (File)
Aug 29 2024, 1:26 PM
Unknown Object (File)
Aug 13 2024, 2:31 AM
Unknown Object (File)
Aug 13 2024, 2:11 AM
Unknown Object (File)
Aug 13 2024, 1:09 AM
Unknown Object (File)
Aug 5 2024, 12:20 AM

Details

Summary

When ip_output_send() returns EAGAIN due to issues with send tags (route change, lagg failover, etc), it must free the mbuf. This is because ip_output_send() was written as a replacement for a direct call to if_output(), and the contract with if_output() has historically been that it owns the mbufs once called. When ip_output_send() failed to free mbufs, it violated this assumption and lead to leaked mbufs.

This was noticed when using NIC TLS in combination with hardware rate-limited connections. When seeing lots of NIC output drops triggered ratelimit send tag changes, we noticed we were leaking tls_sessions, send tags and mbufs. This was due ip_output_send() leaking mbufs which held references to ktls_sessions, which in turn held references to send tags.

Many thanks to @jhb @rrs @hselasky and @markj for helping to debug this at various stages

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable