Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 26, 11:30 PM
Unknown Object (File)
Mon, Apr 14, 11:57 AM
Unknown Object (File)
Sat, Apr 12, 4:37 AM
Unknown Object (File)
Mon, Apr 7, 4:51 AM
Unknown Object (File)
Mar 23 2025, 3:21 PM
Unknown Object (File)
Mar 23 2025, 3:44 AM
Unknown Object (File)
Mar 21 2025, 5:11 PM
Unknown Object (File)
Mar 20 2025, 4:36 PM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44033
Build 40921: arc lint + arc unit