Page MenuHomeFreeBSD
Differential D33942

if_clone: correctly destroy a clone from a different vnet
ClosedPublic
Actions

Authored by glebius on Jan 19 2022, 4:38 AM.
Tags
None
Referenced Files
F107127745: D33942.diff
Fri, Jan 10, 1:26 PM
Unknown Object (File)
Dec 5 2024, 3:36 AM
Unknown Object (File)
Nov 27 2024, 10:17 AM
Unknown Object (File)
Oct 20 2024, 11:01 AM
Unknown Object (File)
Oct 19 2024, 7:22 PM
Unknown Object (File)
Oct 10 2024, 11:58 AM
Unknown Object (File)
Oct 4 2024, 10:41 PM
Unknown Object (File)
Oct 1 2024, 12:53 PM
View All 40 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
bz
zec
Group Reviewers
network
Commits
rGea980c17f48e: if_clone: correctly destroy a clone from a different vnet
rG80fc25025ffc: tests/net*: destroy interface from inside a jail
rG6d1808f051a5: if_clone: correctly destroy a clone from a different vnet
Summary

Try to live with cruel reality fact - if_vmove doesn't move an
interface from previous vnet cloning infrastructure to the new
one. Let's admit this as design feature and make it work better.

  • Delete two blocks of code that would fallback to vnet0, if a cloner isn't found. They didn't do any good job and also whole idea of treating vnet0 as special one is wrong.
  • When deleting a cloned interface, lookup its cloner using it's home vnet.

With this change simple sequence works correctly:

ifconfig foo0 create
jail -c name=jj persist vnet vnet.interface=foo0
jexec jj ifconfig foo0 destroy

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43981
Build 40869: arc lint + arc unit

Event Timeline

glebius created this revision.Jan 19 2022, 4:38 AM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJan 19 2022, 4:38 AM
glebius requested review of this revision.Jan 19 2022, 4:38 AM
Harbormaster completed remote builds in B43981: Diff 101630.Jan 19 2022, 4:38 AM
glebius added a parent revision: D33941: if_vmove: improve restoration in cloner's ifgroup membership.Jan 19 2022, 4:38 AM
glebius added a child revision: D33943: tests/net*: destroy interface from inside a jail.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 25 2022, 5:10 AM
Closed by commit rG6d1808f051a5: if_clone: correctly destroy a clone from a different vnet (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG6d1808f051a5: if_clone: correctly destroy a clone from a different vnet.
glebius added a commit: rG80fc25025ffc: tests/net*: destroy interface from inside a jail.
zlei added a subscriber: zlei.Apr 19 2023, 2:08 PM

Found this while try MFCing some commits for sys/net/if_clone.c.

@bz mentioned similar problem for loaned physical interfaces. https://reviews.freebsd.org/D37957 should fix those problem perfectly.

BTW, I think it is wrong to let loaner vnet destroy the loaned interfaces, anyway it is good for a temporary workaround.

As release/14 is coming, I think I should rush for that.

zlei added a commit: rGea980c17f48e: if_clone: correctly destroy a clone from a different vnet.Oct 10 2024, 10:03 AM

Revision Contents
Changeset List

PathSize
sys/
net/
30 lines

Diff 101630

View Options

sys/net/if_clone.c

Loading...