Differential D33800

fusefs: implement VOP_DEALLOCATE
ClosedPublic
Actions

Authored by asomers on Jan 9 2022, 4:55 AM.

Tags

None

Referenced Files

	F96624307: D33800.id.diff
	Wed, Sep 25, 7:03 PM

	F96391986: D33800.diff
	Tue, Sep 24, 7:26 PM

	Unknown Object (File)
	Tue, Sep 24, 12:41 PM

	Unknown Object (File)
	Sat, Sep 21, 4:50 AM

	Unknown Object (File)
	Fri, Sep 20, 1:14 PM

	Unknown Object (File)
	Fri, Sep 20, 4:40 AM

	Unknown Object (File)
	Thu, Sep 19, 6:21 PM

	Unknown Object (File)
	Wed, Sep 18, 6:44 PM

View All 51 Files

Subscribers

Details

Reviewers

khng
pfg

Commits

rG89d57b94d776: fusefs: implement VOP_DEALLOCATE

Summary

fusefs: implement VOP_DEALLOCATE

MFC after: Never

Test Plan

test cases added. Manual testing for NFS

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jan 9 2022, 4:55 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 9 2022, 4:55 AM

asomers requested review of this revision.Jan 9 2022, 4:55 AM

Harbormaster completed remote builds in B43796: Diff 101161.Jan 9 2022, 4:55 AM

rmacklem added inline comments.Jan 9 2022, 2:37 PM

sys/fs/fuse/fuse_vnops.c
2989	I don't know fuse, but you might need a: if (ap->a_ioflag & IO_SYNC) - do an fsync in here. Like VOP_ALLOCATE(), the nfsd passes IO_SYNC to VOP_DEALLOCATE(), to ensure that the data/metadata is on stable storage before the RPC replies.

asomers added inline comments.Jan 11 2022, 3:13 AM

sys/fs/fuse/fuse_vnops.c
2989	When IO_SYNC is set, is it necessary to flush all buffers for the file, to ensure that the entire file is synced before the RPC replies, or is it only necessary to ensure that this operation is synced?

khng added inline comments.Jan 11 2022, 4:35 AM

sys/fs/fuse/fuse_vnops.c
2989	The intention of IO_SYNC in the VOP is to only ensure this operation is synced.

Properly handle IO_SYNC during VOP_DEALLOCATE for fuse

Harbormaster completed remote builds in B43825: Diff 101249.Jan 11 2022, 5:06 AM

khng accepted this revision.Jan 18 2022, 7:23 PM

This revision is now accepted and ready to land.Jan 18 2022, 7:23 PM

Closed by commit rG89d57b94d776: fusefs: implement VOP_DEALLOCATE (authored by asomers). · Explain WhyJan 19 2022, 4:27 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG89d57b94d776: fusefs: implement VOP_DEALLOCATE.

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

6 lines

115 lines

tests/

sys/

fs/

fusefs/

default_permissions.cc

101 lines

457 lines

Diff 101628

sys/fs/fuse/fuse_kernel.h

Loading...

sys/fs/fuse/fuse_vnops.c

Loading...

tests/sys/fs/fusefs/default_permissions.cc

Loading...

tests/sys/fs/fusefs/fallocate.cc

Loading...