Page MenuHomeFreeBSD
Differential D33739

bhyve: Map the right BAR in init_msix_table()
ClosedPublic
Actions

Authored by markj on Jan 4 2022, 7:11 PM.
Tags
None
Referenced Files
F112113366: D33739.diff
Thu, Mar 13, 12:13 AM
Unknown Object (File)
Sat, Mar 8, 4:22 AM
Unknown Object (File)
Wed, Mar 5, 8:35 PM
Unknown Object (File)
Mon, Mar 3, 2:13 PM
Unknown Object (File)
Mon, Mar 3, 2:05 PM
Unknown Object (File)
Mon, Mar 3, 2:03 PM
Unknown Object (File)
Mon, Feb 24, 4:36 AM
Unknown Object (File)
Feb 4 2025, 7:22 PM
View All 96 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
Group Reviewers
bhyve
Commits
rG4558c11f1b4d: bhyve: Correct unmapping of the MSI-X table BAR
rG76b45e688ae8: bhyve: Map the right BAR in init_msix_table()
Summary

The PBA and MSI-X table can reside in different BARs.

Reported by: Andy Fiddaman <andy@omniosce.org>
Fixes: 7fa233534736 ("bhyve: Map the MSI-X table unconditionally for passthrough")
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43709
Build 40597: arc lint + arc unit

Event Timeline

markj created this revision.Jan 4 2022, 7:11 PM
Herald added a reviewer: bhyve. · View Herald TranscriptJan 4 2022, 7:11 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
markj requested review of this revision.Jan 4 2022, 7:11 PM
Harbormaster completed remote builds in B43700: Diff 100933.Jan 4 2022, 7:11 PM
markj mentioned this in D32359: bhyve: Map the MSI-X table unconditionally when passthrough is enabled.Jan 4 2022, 7:13 PM
markj updated this revision to Diff 100944.Jan 4 2022, 9:32 PM

Fix a second bug, also reported by Andy:

If the last page containing the table is not also the last page
of the BAR, then we would call mprotect(PROT_NONE) on the wrong
portion of the mapping.

Harbormaster completed remote builds in B43709: Diff 100944.Jan 4 2022, 9:32 PM
jhb accepted this revision.Jan 4 2022, 10:35 PM
This revision is now accepted and ready to land.Jan 4 2022, 10:35 PM
Closed by commit rG76b45e688ae8: bhyve: Map the right BAR in init_msix_table() (authored by markj). · Explain WhyJan 5 2022, 3:12 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG76b45e688ae8: bhyve: Map the right BAR in init_msix_table().
markj added a commit: rG4558c11f1b4d: bhyve: Correct unmapping of the MSI-X table BAR.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines

Diff 100944

View Options

usr.sbin/bhyve/pci_passthru.c

Loading...