Page MenuHomeFreeBSD
Differential D33728

bhyve: only init MSI-X table if passthru device supports it
ClosedPublic
Actions

Authored by corvink on Jan 3 2022, 12:26 PM.
Tags
Referenced Files
F98481570: D33728.diff
Thu, Oct 3, 1:17 PM
Unknown Object (File)
Fri, Sep 27, 8:06 AM
Unknown Object (File)
Sun, Sep 22, 2:29 PM
Unknown Object (File)
Wed, Sep 11, 8:10 PM
Unknown Object (File)
Mon, Sep 9, 3:03 AM
Unknown Object (File)
Sat, Sep 7, 2:06 AM
Unknown Object (File)
Wed, Sep 4, 9:25 PM
Unknown Object (File)
Tue, Sep 3, 5:09 PM
View All 50 Files
Subscribers
bcran
bz
imp
rgrimes
bhyve

Details

Reviewers
jhb
markj
manu
bz
Group Reviewers
bhyve
Commits
rG338a1be83630: bhyve: only init MSI-X table if passthru device supports it
Summary

Some passthru devices only support MSI instead of MSI-X. For those
devices the initialization of MSI-X table will fail.

This issue was added by D33628

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

corvink created this revision.Jan 3 2022, 12:26 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJan 3 2022, 12:26 PM
corvink requested review of this revision.Jan 3 2022, 12:26 PM
corvink mentioned this in D33628: bhyve: passthru: enable BARs before possibly mmap(2)ing them.
bz accepted this revision.Jan 3 2022, 2:10 PM
bz added a subscriber: bz.

Sorry for that breakage and thanks for the fix; do you mind if I commit it straight away so I can MFC the proper version?

This revision is now accepted and ready to land.Jan 3 2022, 2:10 PM
manu accepted this revision.Jan 3 2022, 2:13 PM
corvink added a comment.Jan 3 2022, 2:14 PM
In D33728#762550, @bz wrote:

Sorry for that breakage and thanks for the fix; do you mind if I commit it straight away so I can MFC the proper version?

Thanks for your fast response. Of course, you can commit it straight away.

Closed by commit rG338a1be83630: bhyve: only init MSI-X table if passthru device supports it (authored by corvink, committed by bz). · Explain WhyJan 3 2022, 3:04 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG338a1be83630: bhyve: only init MSI-X table if passthru device supports it.
bz mentioned this in rG7ea16192a01e: bhyve: passthru: enable BARs before possibly mmap(2)ing them.Jan 9 2022, 2:40 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
15 lines

Diff 100872

View Options

usr.sbin/bhyve/pci_passthru.c

Loading...