Page MenuHomeFreeBSD
Differential D33700

ctfconvert: Handle arrays of empty structs
ClosedPublic
Actions

Authored by markj on Dec 30 2021, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 19, 12:29 AM
Unknown Object (File)
Sun, Sep 15, 1:30 PM
Unknown Object (File)
Sun, Sep 8, 2:03 AM
Unknown Object (File)
Fri, Sep 6, 1:18 PM
Unknown Object (File)
Thu, Sep 5, 8:44 AM
Unknown Object (File)
Mon, Sep 2, 6:30 AM
Unknown Object (File)
Mon, Sep 2, 6:29 AM
Unknown Object (File)
Mon, Sep 2, 6:29 AM
View All 37 Files
Subscribers
bz
imp

Details

Reviewers
bz
Commits
rG963f5dc7a306: ctfconvert: Handle arrays of empty structs
Summary

Members with such a type will legitimately have a size of zero, so don't
emit a warning.

PR: 260818

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 30 2021, 3:12 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 30 2021, 3:12 PM
markj requested review of this revision.Dec 30 2021, 3:12 PM
Harbormaster completed remote builds in B43650: Diff 100755.Dec 30 2021, 3:12 PM
bz accepted this revision.Dec 30 2021, 5:16 PM
bz added a subscriber: bz.

Sounds good to me; maybe the comment above that block could be enhanced as well but I think it's almost immediately obvious from the code.

This revision is now accepted and ready to land.Dec 30 2021, 5:16 PM
Closed by commit rG963f5dc7a306: ctfconvert: Handle arrays of empty structs (authored by markj). · Explain WhyDec 31 2021, 6:09 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG963f5dc7a306: ctfconvert: Handle arrays of empty structs.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
tools/
ctf/
cvt/
12 lines

Diff 100791

View Options

cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c

Loading...