Page MenuHomeFreeBSD

bhyve nvme: Remove redundant AER Limit checks
ClosedPublic

Authored by chuck on Dec 19 2021, 4:17 PM.
Tags
None
Referenced Files
F113930525: D33570.id102093.diff
Sat, Apr 5, 7:00 PM
Unknown Object (File)
Mon, Mar 31, 10:59 PM
Unknown Object (File)
Feb 21 2025, 10:12 AM
Unknown Object (File)
Feb 21 2025, 6:40 AM
Unknown Object (File)
Feb 20 2025, 12:08 AM
Unknown Object (File)
Feb 15 2025, 7:05 PM
Unknown Object (File)
Feb 3 2025, 12:05 PM
Unknown Object (File)
Jan 31 2025, 3:50 AM

Details

Summary

The NVMe emulation checked if the Asynchronous Event Request Limit
(a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function
is only called from nvme_opc_async_event_req() which also checks for
exceeding the AERL.

While in the neighborhood, fix / enhance the debug logging.

Tested by:
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck requested review of this revision.Dec 19 2021, 4:17 PM
allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 23 2021, 5:16 PM

I don't see the 'while in the area' changes, so omit that from the final commit message.

In D33570#759866, @imp wrote:

I don't see the 'while in the area' changes, so omit that from the final commit message.

Good catch. Fixed.

This revision was automatically updated to reflect the committed changes.