The ithread has been subsumed by the 'interrupt event' object, so
update the description to reflect this by describing an interrupt event
and its contents. We've also moved on from having a single handler
function to the split filter-and-handler model. Explain the purpose and
constraints of these two handlers.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Warnings Severity Location Code Message Warning share/man/man9/ithread.9:106 SPELL1 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 43384 Build 40272: arc lint + arc unit
Event Timeline
| share/man/man9/ithread.9 | ||
|---|---|---|
| 76–78 | line breaks here are weird. | |
| share/man/man9/ithread.9 | ||
|---|---|---|
| 129 | Typo for "intr"? | |
Comment Actions
Rebase. Handle feedback, rework text describing locks and sleeping, and add subsections to organize the description somewhat.
| share/man/man9/intr_event.9 | ||
|---|---|---|
| 92 ↗ | (On Diff #110233) | |
| 107 ↗ | (On Diff #110233) | I think you want to be careful here about the phrase "interrupt handler" to avoid ambiguity. Here I think you mean the threaded handler? |
| 114 ↗ | (On Diff #110233) | Not sure if you want to clarify that you can't call malloc at all in a filter? |
Comment Actions
Update Handler Constraints to address review comments.
Avoid referring to "filter" and "handler" functions as "callbacks".
I discovered that the filter and threaded routines are described in detail
already in bus_setup_intr(9). I think the overlap is acceptable, however.
Comment Actions
Small further tweaks, mainly, clarify that filters are executed in a critical section.
| share/man/man9/intr_event.9 | ||
|---|---|---|
| 114 ↗ | (On Diff #111520) | "forbidden" feels more less stilted than "disallowed" and less likely to be misread by missing "not" than "not permitted". |
| 121–122 ↗ | (On Diff #111520) | Seconded. |
| 124 ↗ | (On Diff #111520) | "should", not "must"? |
| 128 ↗ | (On Diff #111520) | Or "later, outside (mumble) context". |