Page MenuHomeFreeBSD
Differential D33426

rc: network.subr update consitency with older change
ClosedPublic
Actions

Authored by bz on Dec 14 2021, 2:43 AM.
Tags
None
Referenced Files
F102115767: D33426.id142894.diff
Thu, Nov 7, 7:42 PM
F102110775: D33426.diff
Thu, Nov 7, 6:07 PM
Unknown Object (File)
Wed, Nov 6, 6:32 AM
Unknown Object (File)
Tue, Nov 5, 5:46 AM
Unknown Object (File)
Sat, Oct 19, 5:32 PM
Unknown Object (File)
Sat, Oct 19, 10:52 AM
Unknown Object (File)
Sat, Oct 19, 10:52 AM
Unknown Object (File)
Sat, Oct 19, 10:52 AM
View All 30 Files
Subscribers
imp
zlei
network
rc

Details

Reviewers
hrs
zlei
Commits
rG267ad286efd8: rc: network.subr update consitency with older change (v6/v4 order)
rGd60a0ffecfdf: rc: network.subr update consitency with older change (v6/v4 order)
rGed4d2a54fc7a: rc: network.subr update consitency with older change (v6/v4 order)
Summary

As of 1b5be7204eaeeaf58eefdebe5b308f90792c693b we setup parts of IPv6
before IPv4 if configured. For consistency change a case in ifn_start()
calling ipv6_up() before ipv4_up().

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59303
Build 56190: arc lint + arc unit

Event Timeline

bz created this revision.Dec 14 2021, 2:43 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 14 2021, 2:43 AM
bz requested review of this revision.Dec 14 2021, 2:43 AM
Harbormaster completed remote builds in B43329: Diff 99970.Dec 14 2021, 2:44 AM
bz added a comment.Sep 4 2024, 12:21 AM

Anyone objects?
Should we also swap teardown order in ifn_stop_ifn?

zlei accepted this revision.Sep 4 2024, 2:20 AM
zlei added a subscriber: zlei.
In D33426#1060563, @bz wrote:

Anyone objects?

I do not see any problems with this change.

Should we also swap teardown order in ifn_stop_ifn?

Yes I think so.

This revision is now accepted and ready to land.Sep 4 2024, 2:20 AM
bz updated this revision to Diff 142894.Sep 4 2024, 7:07 PM

Also change ifn_stop()

This revision now requires review to proceed.Sep 4 2024, 7:07 PM
Harbormaster completed remote builds in B59303: Diff 142894.Sep 4 2024, 7:07 PM
zlei accepted this revision.Sep 5 2024, 5:05 PM
This revision is now accepted and ready to land.Sep 5 2024, 5:05 PM
Closed by commit rGed4d2a54fc7a: rc: network.subr update consitency with older change (v6/v4 order) (authored by bz). · Explain WhySep 5 2024, 7:55 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGed4d2a54fc7a: rc: network.subr update consitency with older change (v6/v4 order).
bz added a commit: rGd60a0ffecfdf: rc: network.subr update consitency with older change (v6/v4 order).Sep 28 2024, 10:38 AM
bz added a commit: rG267ad286efd8: rc: network.subr update consitency with older change (v6/v4 order).Sep 28 2024, 9:52 PM

Revision Contents
Changeset List

PathSize
libexec/
rc/
4 lines

Diff 142894

View Options

libexec/rc/network.subr

Loading...