x86: add a comment providing source for numbers in legacy XSAVE area layout
ClosedPublic
Actions

Authored by kib on Dec 13 2021, 11:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 26, 2:35 PM

	Unknown Object (File)
	Fri, Mar 21, 4:32 PM

	Unknown Object (File)
	Thu, Mar 13, 2:06 AM

	Unknown Object (File)
	Wed, Mar 12, 9:42 AM

	Unknown Object (File)
	Wed, Mar 12, 7:41 AM

	Unknown Object (File)
	Mon, Mar 10, 1:45 PM

	Unknown Object (File)
	Thu, Mar 6, 8:30 AM

	Unknown Object (File)
	Thu, Mar 6, 8:30 AM

View All 68 Files

Subscribers

imp

Details

Reviewers

emaste
mpratt_google.com

Commits

rG0e6b06d5c871: x86: add a comment providing source for numbers in legacy XSAVE area layout

Summary

Suggested by: Michael Pratt <mpratt@google.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 13 2021, 11:30 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2021, 11:30 PM

kib requested review of this revision.Dec 13 2021, 11:30 PM

mpratt_google.com added inline comments.Dec 14 2021, 4:07 PM

sys/i386/i386/npx.c
533	13.5.2 "SSE State" also states this if you want a closer reference.
533	Quote "SSE State" for consistency with the other section title?

Extend i386 comment, quote title.

LGTM

This revision is now accepted and ready to land.Dec 14 2021, 4:49 PM

emaste accepted this revision.Dec 14 2021, 4:51 PM

Closed by commit rG0e6b06d5c871: x86: add a comment providing source for numbers in legacy XSAVE area layout (authored by kib). · Explain WhyDec 14 2021, 5:15 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0e6b06d5c871: x86: add a comment providing source for numbers in legacy XSAVE area layout.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

fpu.c

3 lines

i386/

npx.c

5 lines

Diff 100009

View Options

sys/amd64/amd64/fpu.c