libdwarf: Fix error handling in _dwarf_elf_init()
ClosedPublic
Actions

Authored by markj on Dec 13 2021, 8:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 9, 2:43 PM

	Unknown Object (File)
	Dec 10 2024, 2:27 PM

	Unknown Object (File)
	Nov 21 2024, 7:34 AM

	Unknown Object (File)
	Nov 18 2024, 5:41 AM

	Unknown Object (File)
	Sep 27 2024, 5:33 AM

	Unknown Object (File)
	Sep 25 2024, 6:16 AM

	Unknown Object (File)
	Sep 23 2024, 10:10 AM

	Unknown Object (File)
	Sep 23 2024, 7:13 AM

View All 50 Files

Subscribers

imp

Details

Reviewers

emaste

Commits

rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init()

Summary

We were not setting "ret" before jumping to the error path, so the
function returned success even when it had failed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 43324
Build 40212: arc lint + arc unit

Event Timeline

markj created this revision.Dec 13 2021, 8:27 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2021, 8:27 PM

markj requested review of this revision.Dec 13 2021, 8:27 PM

Harbormaster completed remote builds in B43324: Diff 99957.Dec 13 2021, 8:27 PM

emaste accepted this revision.Dec 13 2021, 8:28 PM

This revision is now accepted and ready to land.Dec 13 2021, 8:28 PM

Closed by commit rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init() (authored by markj). · Explain WhyDec 13 2021, 11:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc983ec6428ec: libdwarf: Fix error handling in _dwarf_elf_init().

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

libdwarf/

libdwarf_elf_init.c

8 lines

Diff 99957

View Options

contrib/elftoolchain/libdwarf/libdwarf_elf_init.c

libdwarf: Fix error handling in _dwarf_elf_init()ClosedPublicActions